AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tests: port assertEquals() with delta to assertEqualsWithDelta()

Browse Source 
assertEquals() in phpunit 9.5 no longer takes a delta parameter
and has assertEqualsWithDelta() as a replacement. This means
float get compared without a delta atm, and a recent phpunit
release (9.5.25) has made float comparisons stricter resulting in
test suite errors such as:

1) SubtaskTimeTrackingModelTest::testCalculateSubtaskTime
Total spent
Failed asserting that 3.3000000000000003 matches expected 3.3.
tests/units/Model/SubtaskTimeTrackingModelTest.php:186

This replaces all assertEquals() calls that pass a delta value
with assertEqualsWithDelta().
This commit is contained in:
Christoph Reiter
2022-10-10 11:38:19 +02:00
committed by Frédéric Guillot
parent 2d4ee932da
commit 0b8a270bbb
17 changed files with 82 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/units/Model/TaskStatusModelTest.php
View File

@@ -72,7 +72,7 @@ class TaskStatusModelTest extends Base
$this->assertNotEmpty($task);
$this->assertEquals(TaskModel::STATUS_OPEN, $task['is_active']);
$this->assertEquals(0, $task['date_completed']);
$this->assertEquals(time(), $task['date_modification'], '', 1);
$this->assertEqualsWithDelta(time(), $task['date_modification'], 1, '');
// We close the task
@@ -85,8 +85,8 @@ class TaskStatusModelTest extends Base
$task = $taskFinderModel->getById(1);
$this->assertNotEmpty($task);
$this->assertEquals(TaskModel::STATUS_CLOSED, $task['is_active']);
$this->assertEquals(time(), $task['date_completed'], 'Bad completion timestamp', 1);
$this->assertEquals(time(), $task['date_modification'], 'Bad modification timestamp', 1);
$this->assertEqualsWithDelta(time(), $task['date_completed'], 1, 'Bad completion timestamp');
$this->assertEqualsWithDelta(time(), $task['date_modification'], 1, 'Bad modification timestamp');
// We open the task again
@@ -97,7 +97,7 @@ class TaskStatusModelTest extends Base
$this->assertNotEmpty($task);
$this->assertEquals(TaskModel::STATUS_OPEN, $task['is_active']);
$this->assertEquals(0, $task['date_completed']);
$this->assertEquals(time(), $task['date_modification'], '', 1);
$this->assertEqualsWithDelta(time(), $task['date_modification'], 1, '');
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertCount(2, $called);