AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Show all tasks when using no search criteria

Browse Source
This commit is contained in:
Frederic Guillot
2015-08-19 21:12:17 -04:00
parent 57bd53847c
commit 1983fc5f7a
3 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
ChangeLog
View File

@@ -17,6 +17,7 @@ New features:
Improvements: Improvements:
* Show all tasks when using no search criteria
* Add column vertical scrolling * Add column vertical scrolling
* Set dynamically column height based on viewport size * Set dynamically column height based on viewport size
* Enable support for Github Enterprise when using Github Authentication * Enable support for Github Enterprise when using Github Authentication

2
app/Model/TaskFilter.php
View File

@@ -36,7 +36,7 @@ class TaskFilter extends Base
$this->query = $this->taskFinder->getExtendedQuery(); $this->query = $this->taskFinder->getExtendedQuery();
if (empty($tree)) { if (empty($tree)) {
$this->query->addCondition('1 = 0'); $this->filterByTitle($input);
} }
foreach ($tree as $filter => $value) { foreach ($tree as $filter => $value) {

18
tests/units/TaskFilterTest.php
View File

@@ -80,6 +80,24 @@ class TaskFilterTest extends Base
$this->assertEmpty($tf->search('search something')->findAll()); $this->assertEmpty($tf->search('search something')->findAll());
} }
public function testSearchWithEmptyInput()
{
$dp = new DateParser($this->container);
$p = new Project($this->container);
$tc = new TaskCreation($this->container);
$tf = new TaskFilter($this->container);
$this->assertEquals(1, $p->create(array('name' => 'test')));
$this->assertNotFalse($tc->create(array('project_id' => 1, 'title' => 'my task title is awesome', 'date_due' => $dp->getTimestampFromIsoFormat('-2 days'))));
$this->assertNotFalse($tc->create(array('project_id' => 1, 'title' => 'my task title is amazing', 'date_due' => $dp->getTimestampFromIsoFormat('+1 day'))));
$this->assertNotFalse($tc->create(array('project_id' => 1, 'title' => 'Bob at work', 'date_due' => $dp->getTimestampFromIsoFormat('-1 day'))));
$this->assertNotFalse($tc->create(array('project_id' => 1, 'title' => 'youpi', 'date_due' => $dp->getTimestampFromIsoFormat(time()))));
$result = $tf->search('')->findAll();
$this->assertNotEmpty($result);
$this->assertCount(4, $result);
}
public function testSearchById() public function testSearchById()
{ {
$p = new Project($this->container); $p = new Project($this->container);