AS1024
/
Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed identical background color for LetterAvatar on 32bits platforms

This commit is contained in:
Frederic Guillot 2016-06-29 21:45:28 -04:00
parent 6c24ec5784
commit 1aab142127
No known key found for this signature in database
GPG Key ID: 92D77191BA7FBC99
3 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ChangeLog
View File

@ -20,6 +20,7 @@ Improvements:
Bug fixes: Bug fixes:
* Fixed broken CSV exports * Fixed broken CSV exports
* Fixed identical background color for LetterAvatar on 32bits platforms (Hash greater than PHP_MAX_INT)
Version 1.0.30 Version 1.0.30
-------------- --------------

2
app/User/Avatar/LetterAvatarProvider.php
View File

@ -142,7 +142,7 @@ class LetterAvatarProvider extends Base implements AvatarProviderInterface
// Make hash more sensitive for short string like 'a', 'b', 'c' // Make hash more sensitive for short string like 'a', 'b', 'c'
$str .= 'x'; $str .= 'x';
$max = intval(9007199254740991 / $seed2); $max = intval(PHP_INT_MAX / $seed2);
for ($i = 0, $ilen = mb_strlen($str, 'UTF-8'); $i < $ilen; $i++) { for ($i = 0, $ilen = mb_strlen($str, 'UTF-8'); $i < $ilen; $i++) {
if ($hash > $max) { if ($hash > $max) {

2
tests/units/User/Avatar/LetterAvatarProviderTest.php
View File

@ -23,7 +23,7 @@ class LetterAvatarProviderTest extends Base
{ {
$provider = new LetterAvatarProvider($this->container); $provider = new LetterAvatarProvider($this->container);
$user = array('id' => 123, 'name' => 'Kanboard Admin', 'username' => 'bob', 'email' => ''); $user = array('id' => 123, 'name' => 'Kanboard Admin', 'username' => 'bob', 'email' => '');
$expected = '<div class="avatar-letter" style="background-color: rgb(131, 224, 108)" title="Kanboard Admin">KA</div>'; $expected = '<div class="avatar-letter" style="background-color: rgb(120, 83, 58)" title="Kanboard Admin">KA</div>';
$this->assertEquals($expected, $provider->render($user, 48)); $this->assertEquals($expected, $provider->render($user, 48));
} }