AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix bug duplicate project with a too long name

Browse Source
This commit is contained in:
Frederic Guillot
2015-01-25 18:08:28 -05:00
parent e6cf1bf236
commit 1fc6d69e2e
7 changed files with 185 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

96
tests/units/ProjectDuplicateTest.php → tests/units/ProjectDuplicationTest.php
View File

@@ -2,9 +2,11 @@
require_once __DIR__.'/Base.php';
use Model\Action;
use Model\Project;
use Model\Category;
use Model\ProjectPermission;
use Model\ProjectDuplication;
use Model\User;
use Model\Task;
use Model\TaskCreation;
@@ -13,12 +15,39 @@ use Model\Board;
class ProjectDuplicationTest extends Base
{
public function testProjectName()
{
$pd = new ProjectDuplication($this->container);
$this->assertEquals('test (Clone)', $pd->getClonedProjectName('test'));
$this->assertEquals(50, strlen($pd->getClonedProjectName(str_repeat('a', 50))));
$this->assertEquals(str_repeat('a', 42).' (Clone)', $pd->getClonedProjectName(str_repeat('a', 50)));
$this->assertEquals(50, strlen($pd->getClonedProjectName(str_repeat('a', 60))));
$this->assertEquals(str_repeat('a', 42).' (Clone)', $pd->getClonedProjectName(str_repeat('a', 60)));
}
public function testCopyProjectWithLongName()
{
$p = new Project($this->container);
$pd = new ProjectDuplication($this->container);
$this->assertEquals(1, $p->create(array('name' => str_repeat('a', 50))));
$this->assertEquals(2, $pd->duplicate(1));
$project = $p->getById(2);
$this->assertNotEmpty($project);
$this->assertEquals(str_repeat('a', 42).' (Clone)', $project['name']);
}
public function testClonePublicProject()
{
$p = new Project($this->container);
$pd = new ProjectDuplication($this->container);
$this->assertEquals(1, $p->create(array('name' => 'Public')));
$this->assertEquals(2, $p->duplicate(1));
$this->assertEquals(2, $pd->duplicate(1));
$project = $p->getById(2);
$this->assertNotEmpty($project);
@@ -31,9 +60,10 @@ class ProjectDuplicationTest extends Base
public function testClonePrivateProject()
{
$p = new Project($this->container);
$pd = new ProjectDuplication($this->container);
$this->assertEquals(1, $p->create(array('name' => 'Private', 'is_private' => 1), 1, true));
$this->assertEquals(2, $p->duplicate(1));
$this->assertEquals(2, $pd->duplicate(1));
$project = $p->getById(2);
$this->assertNotEmpty($project);
@@ -52,6 +82,7 @@ class ProjectDuplicationTest extends Base
{
$p = new Project($this->container);
$c = new Category($this->container);
$pd = new ProjectDuplication($this->container);
$this->assertEquals(1, $p->create(array('name' => 'P1')));
@@ -59,7 +90,7 @@ class ProjectDuplicationTest extends Base
$this->assertEquals(2, $c->create(array('name' => 'C2', 'project_id' => 1)));
$this->assertEquals(3, $c->create(array('name' => 'C3', 'project_id' => 1)));
$this->assertEquals(2, $p->duplicate(1));
$this->assertEquals(2, $pd->duplicate(1));
$project = $p->getById(2);
$this->assertNotEmpty($project);
@@ -85,6 +116,7 @@ class ProjectDuplicationTest extends Base
$c = new Category($this->container);
$pp = new ProjectPermission($this->container);
$u = new User($this->container);
$pd = new ProjectDuplication($this->container);
$this->assertEquals(2, $u->create(array('username' => 'unittest1', 'password' => 'unittest')));
$this->assertEquals(3, $u->create(array('username' => 'unittest2', 'password' => 'unittest')));
@@ -101,7 +133,7 @@ class ProjectDuplicationTest extends Base
$this->assertTrue($pp->isManager(1, 3));
$this->assertFalse($pp->isManager(1, 4));
$this->assertEquals(2, $p->duplicate(1));
$this->assertEquals(2, $pd->duplicate(1));
$project = $p->getById(2);
$this->assertNotEmpty($project);
@@ -115,4 +147,60 @@ class ProjectDuplicationTest extends Base
$this->assertTrue($pp->isManager(2, 3));
$this->assertFalse($pp->isManager(2, 4));
}
public function testCloneProjectWithActionTaskAssignCurrentUser()
{
$p = new Project($this->container);
$a = new Action($this->container);
$pd = new ProjectDuplication($this->container);
$this->assertEquals(1, $p->create(array('name' => 'P1')));
$this->assertTrue($a->create(array(
'project_id' => 1,
'event_name' => Task::EVENT_MOVE_COLUMN,
'action_name' => 'TaskAssignCurrentUser',
'params' => array('column_id' => 2),
)));
$this->assertEquals(2, $pd->duplicate(1));
$actions = $a->getAllByProject(2);
$this->assertNotEmpty($actions);
$this->assertEquals('TaskAssignCurrentUser', $actions[0]['action_name']);
$this->assertNotEmpty($actions[0]['params']);
$this->assertEquals(6, $actions[0]['params'][0]['value']);
}
public function testCloneProjectWithActionTaskAssignColorCategory()
{
$p = new Project($this->container);
$a = new Action($this->container);
$c = new Category($this->container);
$pd = new ProjectDuplication($this->container);
$this->assertEquals(1, $p->create(array('name' => 'P1')));
$this->assertEquals(1, $c->create(array('name' => 'C1', 'project_id' => 1)));
$this->assertEquals(2, $c->create(array('name' => 'C2', 'project_id' => 1)));
$this->assertEquals(3, $c->create(array('name' => 'C3', 'project_id' => 1)));
$this->assertTrue($a->create(array(
'project_id' => 1,
'event_name' => Task::EVENT_CREATE_UPDATE,
'action_name' => 'TaskAssignColorCategory',
'params' => array('color_id' => 'blue', 'category_id' => 2),
)));
$this->assertEquals(2, $pd->duplicate(1));
$actions = $a->getAllByProject(2);
$this->assertNotEmpty($actions);
$this->assertEquals('TaskAssignColorCategory', $actions[0]['action_name']);
$this->assertNotEmpty($actions[0]['params']);
$this->assertEquals('blue', $actions[0]['params'][0]['value']);
$this->assertEquals(5, $actions[0]['params'][1]['value']);
}
}