AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Force integer type for aggregated metrics

Browse Source
This commit is contained in:
Frederic Guillot
2016-03-22 20:58:46 -04:00
parent 8768a4e369
commit 2425fd85c0
3 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
ChangeLog
View File

@@ -27,6 +27,7 @@ Improvements:
Bug fixes: Bug fixes:
* Force integer type for aggregated metrics (Burndown chart concat values instead of summing)
* Fixes cycle time calculation when the start date is defined in the future * Fixes cycle time calculation when the start date is defined in the future
* Access allowed to any tasks from the shared public board by changing the URL parameters * Access allowed to any tasks from the shared public board by changing the URL parameters
* Fix invalid user filter for API procedure createLdapUser() * Fix invalid user filter for API procedure createLdapUser()

2
app/Model/ProjectDailyColumnStats.php
View File

@@ -165,7 +165,7 @@ class ProjectDailyColumnStats extends Base
{ {
foreach ($metrics as $metric) { foreach ($metrics as $metric) {
if ($metric['day'] === $day && $metric['column_id'] == $column_id) { if ($metric['day'] === $day && $metric['column_id'] == $column_id) {
return $metric[$field]; return (int) $metric[$field];
} }
} }

4
tests/units/Model/ProjectDailyColumnStatsTest.php
View File

@@ -244,7 +244,7 @@ class ProjectDailyColumnStatsTest extends Base
array('2016-01-18', 4, 5, 3, 0), array('2016-01-18', 4, 5, 3, 0),
); );
$this->assertEquals($expected, $projectDailyColumnStats->getAggregatedMetrics(1, '2016-01-16', '2016-01-18')); $this->assertSame($expected, $projectDailyColumnStats->getAggregatedMetrics(1, '2016-01-16', '2016-01-18'));
$expected = array( $expected = array(
array('Date', 'Backlog', 'Ready', 'Work in progress', 'Done'), array('Date', 'Backlog', 'Ready', 'Work in progress', 'Done'),
@@ -253,7 +253,7 @@ class ProjectDailyColumnStatsTest extends Base
array('2016-01-18', 11, 14, 1, 0), array('2016-01-18', 11, 14, 1, 0),
); );
$this->assertEquals($expected, $projectDailyColumnStats->getAggregatedMetrics(1, '2016-01-16', '2016-01-18', 'score')); $this->assertSame($expected, $projectDailyColumnStats->getAggregatedMetrics(1, '2016-01-16', '2016-01-18', 'score'));
} }
private function createTasks($column_id, $score, $is_active) private function createTasks($column_id, $score, $is_active)