From 3813acf199a5873c6f5f8ff945e8a83ea745b8af Mon Sep 17 00:00:00 2001 From: Frederic Guillot Date: Sun, 10 Jul 2016 22:05:45 -0400 Subject: [PATCH] Fixed compatibility issue with PHP 5.3 for OAuthUserProvider class --- ChangeLog | 4 ++++ app/User/OAuthUserProvider.php | 14 +++----------- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/ChangeLog b/ChangeLog index 9004af40f..8074c3d71 100644 --- a/ChangeLog +++ b/ChangeLog @@ -10,6 +10,10 @@ Improvements: * Display TOTP issuer for 2FA +Bug fixes: + +* Fixed compatibility issue with PHP 5.3 for OAuthUserProvider class + Version 1.0.31 -------------- diff --git a/app/User/OAuthUserProvider.php b/app/User/OAuthUserProvider.php index dec262504..e5fedcca9 100644 --- a/app/User/OAuthUserProvider.php +++ b/app/User/OAuthUserProvider.php @@ -12,14 +12,6 @@ use Kanboard\Core\User\UserProviderInterface; */ abstract class OAuthUserProvider implements UserProviderInterface { - /** - * Get external id column name - * - * @access public - * @return string - */ - abstract public function getExternalIdColumn(); - /** * User properties * @@ -69,7 +61,7 @@ abstract class OAuthUserProvider implements UserProviderInterface */ public function getExternalId() { - return $this->user['id']; + return isset($this->user['id']) ? $this->user['id'] : ''; } /** @@ -102,7 +94,7 @@ abstract class OAuthUserProvider implements UserProviderInterface */ public function getName() { - return $this->user['name']; + return isset($this->user['name']) ? $this->user['name'] : ''; } /** @@ -113,7 +105,7 @@ abstract class OAuthUserProvider implements UserProviderInterface */ public function getEmail() { - return $this->user['email']; + return isset($this->user['email']) ? $this->user['email'] : ''; } /**