Fix some Scrutinizer issues
This commit is contained in:
parent
20b60bc628
commit
3ba8e06632
|
|
@ -51,7 +51,7 @@ abstract class Base implements Listener
|
|||
* Container instance
|
||||
*
|
||||
* @access protected
|
||||
* @var Pimple\Container
|
||||
* @var \Pimple\Container
|
||||
*/
|
||||
protected $container;
|
||||
|
||||
|
|
|
|||
|
|
@ -29,7 +29,7 @@ abstract class Base
|
|||
* Container instance
|
||||
*
|
||||
* @access protected
|
||||
* @var Pimple\Container
|
||||
* @var \Pimple\Container
|
||||
*/
|
||||
protected $container;
|
||||
|
||||
|
|
|
|||
|
|
@ -104,7 +104,7 @@ class Ldap extends Base
|
|||
{
|
||||
$ldap = $this->connect();
|
||||
|
||||
if ($this->bind($ldap, $username, $password)) {
|
||||
if (is_resource($ldap) && $this->bind($ldap, $username, $password)) {
|
||||
return $this->search($ldap, $username, $password);
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -3,7 +3,7 @@
|
|||
namespace Controller;
|
||||
|
||||
use Model\Project as ProjectModel;
|
||||
use Model\SubTask;
|
||||
use Model\SubTask as SubTaskModel;
|
||||
use Helper;
|
||||
|
||||
/**
|
||||
|
|
@ -87,7 +87,7 @@ class App extends Base
|
|||
*/
|
||||
private function getSubtaskPagination($user_id, $paginate, $offset, $order, $direction)
|
||||
{
|
||||
$status = array(SubTask::STATUS_TODO, SubTask::STATUS_INPROGRESS);
|
||||
$status = array(SubTaskModel::STATUS_TODO, SubTaskModel::STATUS_INPROGRESS);
|
||||
$limit = 10;
|
||||
|
||||
if (! in_array($order, array('tasks.id', 'project_name', 'status', 'title'))) {
|
||||
|
|
|
|||
|
|
@ -55,7 +55,7 @@ abstract class Base
|
|||
* Request instance
|
||||
*
|
||||
* @accesss protected
|
||||
* @var Core\Request
|
||||
* @var \Core\Request
|
||||
*/
|
||||
protected $request;
|
||||
|
||||
|
|
@ -63,7 +63,7 @@ abstract class Base
|
|||
* Response instance
|
||||
*
|
||||
* @accesss protected
|
||||
* @var Core\Response
|
||||
* @var \Core\Response
|
||||
*/
|
||||
protected $response;
|
||||
|
||||
|
|
@ -71,7 +71,7 @@ abstract class Base
|
|||
* Template instance
|
||||
*
|
||||
* @accesss protected
|
||||
* @var Core\Template
|
||||
* @var \Core\Template
|
||||
*/
|
||||
protected $template;
|
||||
|
||||
|
|
@ -79,7 +79,7 @@ abstract class Base
|
|||
* Session instance
|
||||
*
|
||||
* @accesss public
|
||||
* @var Core\Session
|
||||
* @var \Core\Session
|
||||
*/
|
||||
protected $session;
|
||||
|
||||
|
|
@ -87,7 +87,7 @@ abstract class Base
|
|||
* Container instance
|
||||
*
|
||||
* @access private
|
||||
* @var Pimple\Container
|
||||
* @var \Pimple\Container
|
||||
*/
|
||||
private $container;
|
||||
|
||||
|
|
|
|||
|
|
@ -32,7 +32,7 @@ class Router
|
|||
* Container instance
|
||||
*
|
||||
* @access private
|
||||
* @var Pimple\Container
|
||||
* @var \Pimple\Container
|
||||
*/
|
||||
private $container;
|
||||
|
||||
|
|
@ -40,9 +40,9 @@ class Router
|
|||
* Constructor
|
||||
*
|
||||
* @access public
|
||||
* @param Pimple\Container $container Container instance
|
||||
* @param string $controller Controller name
|
||||
* @param string $action Action name
|
||||
* @param \Pimple\Container $container Container instance
|
||||
* @param string $controller Controller name
|
||||
* @param string $action Action name
|
||||
*/
|
||||
public function __construct(Container $container, $controller = '', $action = '')
|
||||
{
|
||||
|
|
|
|||
|
|
@ -25,7 +25,7 @@ abstract class Base implements Listener
|
|||
* Container instance
|
||||
*
|
||||
* @access protected
|
||||
* @var Pimple\Container
|
||||
* @var \Pimple\Container
|
||||
*/
|
||||
protected $container;
|
||||
|
||||
|
|
|
|||
|
|
@ -63,7 +63,7 @@ abstract class Base
|
|||
* Container instance
|
||||
*
|
||||
* @access protected
|
||||
* @var Pimple\Container
|
||||
* @var \Pimple\Container
|
||||
*/
|
||||
protected $container;
|
||||
|
||||
|
|
|
|||
Loading…
Reference in New Issue