AS1024
/
Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(mssql): when updating an object by id, omit the id itself 

It is a useless update and id is an identity column in MSSQL,
which is not updatable and throws an error if you try.

This affects the following seven objects (Models):
- Category
- CustomFilter
- Group
- Project
- Subtask
- TaskExternalLink
- User
This commit is contained in:
Joe Nahmias 2022-07-08 17:38:45 -04:00 committed by Frédéric Guillot
parent 29df527979
commit 3df89f9df2
7 changed files with 21 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/Model/CategoryModel.php
View File

@ -170,7 +170,9 @@ class CategoryModel extends Base
*/
public function update(array $values)
{
return $this->db->table(self::TABLE)->eq('id', $values['id'])->save($values);
$updates = $values;
unset($updates['id']);
return $this->db->table(self::TABLE)->eq('id', $values['id'])->save($updates);
}
/**

4
app/Model/CustomFilterModel.php
View File

@ -85,9 +85,11 @@ class CustomFilterModel extends Base
*/
public function update(array $values)
{
$updates = $values;
unset($updates['id']);
return $this->db->table(self::TABLE)
->eq('id', $values['id'])
->update($values);
->update($updates);
}
/**

4
app/Model/GroupModel.php
View File

@ -132,7 +132,9 @@ class GroupModel extends Base
*/
public function update(array $values)
{
return $this->db->table(self::TABLE)->eq('id', $values['id'])->update($values);
$updates = $values;
unset($updates['id']);
return $this->db->table(self::TABLE)->eq('id', $values['id'])->update($updates);
}
/**

4
app/Model/ProjectModel.php
View File

@ -483,8 +483,10 @@ class ProjectModel extends Base
$this->helper->model->convertIntegerFields($values, array('priority_default', 'priority_start', 'priority_end', 'task_limit'));
$updates = $values;
unset($updates['id']);
return $this->exists($values['id']) &&
$this->db->table(self::TABLE)->eq('id', $values['id'])->save($values);
$this->db->table(self::TABLE)->eq('id', $values['id'])->save($updates);
}
/**

4
app/Model/SubtaskModel.php
View File

@ -237,7 +237,9 @@ class SubtaskModel extends Base
public function update(array $values, $fireEvent = true)
{
$this->prepare($values);
$result = $this->db->table(self::TABLE)->eq('id', $values['id'])->save($values);
$updates = $values;
unset($updates['id']);
$result = $this->db->table(self::TABLE)->eq('id', $values['id'])->save($updates);
if ($result) {
$subtask = $this->getById($values['id']);

4
app/Model/TaskExternalLinkModel.php
View File

@ -84,7 +84,9 @@ class TaskExternalLinkModel extends Base
public function update(array $values)
{
$values['date_modification'] = time();
return $this->db->table(self::TABLE)->eq('id', $values['id'])->update($values);
$updates = $values;
unset($updates['id']);
return $this->db->table(self::TABLE)->eq('id', $values['id'])->update($updates);
}
/**

4
app/Model/UserModel.php
View File

@ -290,7 +290,9 @@ class UserModel extends Base
public function update(array $values)
{
$this->prepare($values);
$result = $this->db->table(self::TABLE)->eq('id', $values['id'])->update($values);
$updates = $values;
unset($updates['id']);
$result = $this->db->table(self::TABLE)->eq('id', $values['id'])->update($updates);
$this->userSession->refresh($values['id']);
return $result;
}