AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve Link::getOppositeLinkId()

Browse Source
This commit is contained in:
Frederic Guillot
2015-05-09 23:00:23 -04:00
parent 1176a489ab
commit 4641d4cf77
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/Model/Link.php
View File

@@ -55,8 +55,7 @@ class Link extends Base
*/ */
public function getOppositeLinkId($link_id) public function getOppositeLinkId($link_id)
{ {
$link = $this->getById($link_id); return $this->db->table(self::TABLE)->eq('id', $link_id)->findOneColumn('opposite_id') ?: $link_id;
return $link['opposite_id'] ?: $link_id;
} }
/** /**

12
tests/units/LinkTest.php
View File

@@ -36,6 +36,18 @@ class LinkTest extends Base
$this->assertNotEquals($link1['opposite_id'], $link2['opposite_id']); $this->assertNotEquals($link1['opposite_id'], $link2['opposite_id']);
} }
public function testGetOppositeLinkId()
{
$l = new Link($this->container);
$this->assertTrue($l->create('Link A'));
$this->assertTrue($l->create('Link B', 'Link C'));
$this->assertEquals(1, $l->getOppositeLinkId(1));
$this->assertEquals(3, $l->getOppositeLinkId(2));
$this->assertEquals(2, $l->getOppositeLinkId(3));
}
public function testUpdate() public function testUpdate()
{ {
$l = new Link($this->container); $l = new Link($this->container);