AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Included Subtask when filtering Tasks by Assignee

Browse Source 
I wrote some unit test specifing the behaviour.
I think only Substask with a Status != Done and an assigned user should be taken into account. The search for "nobody" should not reveal tasks with assigned users when these tasks have a subtask without an user.
This commit is contained in:
Lesstat
2015-07-11 11:38:04 +02:00
parent e7b967d743
commit 5101eaa806
2 changed files with 65 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
app/Model/TaskFilter.php
View File

@@ -313,10 +313,11 @@ class TaskFilter extends Base
$this->query->beginOr();
foreach ($values as $assignee) {
$subtaskQuery = $this->buildSubtaskQuery();
switch ($assignee) {
case 'me':
$this->query->eq(Task::TABLE.'.owner_id', $this->userSession->getId());
$subtaskQuery->eq(Subtask::TABLE.'user_id',$this->userSession->getId() );
break;
case 'nobody':
$this->query->eq(Task::TABLE.'.owner_id', 0);
@@ -324,6 +325,12 @@ class TaskFilter extends Base
default:
$this->query->ilike(User::TABLE.'.username', '%'.$assignee.'%');
$this->query->ilike(User::TABLE.'.name', '%'.$assignee.'%');
$subtaskQuery->ilike(User::TABLE.'.username', '%'.$assignee.'%');
$subtaskQuery->ilike(User::TABLE.'.name', '%'.$assignee.'%');
}
if ($assignee != 'nobody'){
$subtasks = $subtaskQuery->findAll();
$this->addTasksWithFoundSubtask($subtasks);
}
}
@@ -760,4 +767,25 @@ class TaskFilter extends Base
return $this;
}
private function buildSubtaskQuery(){
return $this->db->table(Subtask::TABLE)
->columns(
Subtask::TABLE.'.user_id',
Subtask::TABLE.'.task_id',
User::TABLE.'.name',
User::TABLE.'.username')
->join(User::TABLE, 'id', 'user_id', Subtask::TABLE)
->beginOr()
->eq(Subtask::TABLE.'.status', Subtask::STATUS_TODO)
->eq(Subtask::TABLE.'.status', Subtask::STATUS_INPROGRESS)
->closeOr();
}
private function addTasksWithFoundSubtask($subtasks) {
foreach ($subtasks as $subtask) {
$this->query->eq(Task::TABLE.'.id',$subtask['task_id']);
}
}
}