Remove SubtaskTimeTrackingSubscriber

This commit is contained in:
Frederic Guillot
2016-07-23 22:50:20 -04:00
parent 24555080fd
commit 5884c65a02
8 changed files with 114 additions and 58 deletions

View File

@@ -173,6 +173,7 @@ class SubtaskModel extends Base
$subtask_id = $this->db->table(self::TABLE)->persist($values);
if ($subtask_id !== false) {
$this->subtaskTimeTrackingModel->updateTaskTimeTracking($values['task_id']);
$this->queueManager->push($this->subtaskEventJob->withParams($subtask_id, self::EVENT_CREATE));
}
@@ -183,17 +184,21 @@ class SubtaskModel extends Base
* Update
*
* @access public
* @param array $values Form values
* @param bool $fire_events If true, will be called an event
* @param array $values
* @param bool $fire_event
* @return bool
*/
public function update(array $values, $fire_events = true)
public function update(array $values, $fire_event = true)
{
$this->prepare($values);
$result = $this->db->table(self::TABLE)->eq('id', $values['id'])->save($values);
if ($result && $fire_events) {
$this->queueManager->push($this->subtaskEventJob->withParams($values['id'], self::EVENT_UPDATE, $values));
if ($result) {
$this->subtaskTimeTrackingModel->updateTaskTimeTracking($values['task_id']);
if ($fire_event) {
$this->queueManager->push($this->subtaskEventJob->withParams($values['id'], self::EVENT_UPDATE, $values));
}
}
return $result;

View File

@@ -63,8 +63,11 @@ class SubtaskStatusModel extends Base
if (empty($subtask['user_id']) && $this->userSession->isLogged()) {
$values['user_id'] = $this->userSession->getId();
$subtask['user_id'] = $values['user_id'];
}
$this->subtaskTimeTrackingModel->toggleTimer($subtask_id, $subtask['user_id'], $status);
return $this->subtaskModel->update($values) ? $status : false;
}

View File

@@ -159,6 +159,28 @@ class SubtaskTimeTrackingModel extends Base
return $this->db->table(self::TABLE)->eq('subtask_id', $subtask_id)->eq('user_id', $user_id)->eq('end', 0)->exists();
}
/**
* Start or stop timer according to subtask status
*
* @access public
* @param integer $subtask_id
* @param integer $user_id
* @param integer $status
* @return boolean
*/
public function toggleTimer($subtask_id, $user_id, $status)
{
if ($this->configModel->get('subtask_time_tracking') == 1) {
if ($status == SubtaskModel::STATUS_INPROGRESS) {
return $this->subtaskTimeTrackingModel->logStartTime($subtask_id, $user_id);
} elseif ($status == SubtaskModel::STATUS_DONE) {
return $this->subtaskTimeTrackingModel->logEndTime($subtask_id, $user_id);
}
}
return false;
}
/**
* Log start time
*
@@ -252,7 +274,6 @@ class SubtaskTimeTrackingModel extends Base
{
$subtask = $this->subtaskModel->getById($subtask_id);
// Fire the event subtask.update
return $this->subtaskModel->update(array(
'id' => $subtask['id'],
'time_spent' => $subtask['time_spent'] + $time_spent,