AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Various fixes for PHPAnalyzer

Browse Source
This commit is contained in:
Frederic Guillot
2015-04-03 18:32:51 -04:00
parent 91a5ec0885
commit 5a29cccc95
30 changed files with 48 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/Auth/Base.php
View File

@@ -10,6 +10,7 @@ use Pimple\Container;
* @package auth
* @author Frederic Guillot
*
* @property \Core\Session $session
* @property \Model\Acl $acl
* @property \Model\LastLogin $lastLogin
* @property \Model\User $user

2
app/Auth/GitHub.php
View File

@@ -34,7 +34,7 @@ class GitHub extends Base
{
$user = $this->user->getByGitHubId($github_id);
if ($user) {
if (! empty($user)) {
$this->userSession->refresh($user);
$this->container['dispatcher']->dispatch('auth.success', new AuthEvent(self::AUTH_NAME, $user['id']));
return true;

2
app/Auth/Google.php
View File

@@ -35,7 +35,7 @@ class Google extends Base
{
$user = $this->user->getByGoogleId($google_id);
if ($user) {
if (! empty($user)) {
$this->userSession->refresh($user);
$this->container['dispatcher']->dispatch('auth.success', new AuthEvent(self::AUTH_NAME, $user['id']));
return true;

4
app/Auth/Ldap.php
View File

@@ -36,7 +36,7 @@ class Ldap extends Base
$user = $this->user->getByUsername($username);
if ($user) {
if (! empty($user)) {
// There is already a local user with that name
if ($user['is_ldap_user'] == 0) {
@@ -241,7 +241,7 @@ class Ldap extends Base
}
// User id not retrieved: LDAP_ACCOUNT_ID not properly configured
if (! $username && ! isset($info[0][LDAP_ACCOUNT_ID][0])) {
if (empty($username) && ! isset($info[0][LDAP_ACCOUNT_ID][0])) {
return false;
}

2
app/Auth/ReverseProxy.php
View File

@@ -32,7 +32,7 @@ class ReverseProxy extends Base
$login = $_SERVER[REVERSE_PROXY_USER_HEADER];
$user = $this->user->getByUsername($login);
if (! $user) {
if (empty($user)) {
$this->createUser($login);
$user = $this->user->getByUsername($login);
}