Various fixes for PHPAnalyzer

This commit is contained in:
Frederic Guillot
2015-04-03 18:32:51 -04:00
parent 91a5ec0885
commit 5a29cccc95
30 changed files with 48 additions and 38 deletions

View File

@@ -117,7 +117,7 @@ class Board extends Base
$project = $this->project->getByToken($token);
// Token verification
if (! $project) {
if (empty($project)) {
$this->forbidden(true);
}
@@ -311,7 +311,7 @@ class Board extends Base
$this->checkCSRFParam();
$column = $this->board->getColumn($this->request->getIntegerParam('column_id'));
if ($column && $this->board->removeColumn($column['id'])) {
if (! empty($column) && $this->board->removeColumn($column['id'])) {
$this->session->flash(t('Column removed successfully.'));
} else {
$this->session->flashError(t('Unable to remove this column.'));