AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Various fixes for PHPAnalyzer

Browse Source
This commit is contained in:
Frederic Guillot
2015-04-03 18:32:51 -04:00
parent 91a5ec0885
commit 5a29cccc95
30 changed files with 48 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/Integration/Base.php
View File

@@ -10,6 +10,7 @@ use Pimple\Container;
* @package integration
* @author Frederic Guillot
*
* @property \Model\ProjectActivity $projectActivity
* @property \Model\Task $task
* @property \Model\TaskFinder $taskFinder
* @property \Model\User $user

2
app/Integration/BitbucketWebhook.php
View File

@@ -78,7 +78,7 @@ class BitbucketWebhook extends Base
$task = $this->taskFinder->getById($task_id);
if (! $task) {
if (empty($task)) {
return false;
}

16
app/Integration/GithubWebhook.php
View File

@@ -86,7 +86,7 @@ class GithubWebhook extends Base
$task = $this->taskFinder->getById($task_id);
if (! $task) {
if (empty($task)) {
continue;
}
@@ -142,7 +142,7 @@ class GithubWebhook extends Base
$task = $this->taskFinder->getByReference($payload['issue']['number']);
$user = $this->user->getByUsername($payload['comment']['user']['login']);
if ($task && $user) {
if (! empty($task) && ! empty($user)) {
$event = array(
'project_id' => $this->project_id,
@@ -198,7 +198,7 @@ class GithubWebhook extends Base
{
$task = $this->taskFinder->getByReference($issue['number']);
if ($task) {
if (! empty($task)) {
$event = array(
'project_id' => $this->project_id,
'task_id' => $task['id'],
@@ -227,7 +227,7 @@ class GithubWebhook extends Base
{
$task = $this->taskFinder->getByReference($issue['number']);
if ($task) {
if (! empty($task)) {
$event = array(
'project_id' => $this->project_id,
'task_id' => $task['id'],
@@ -257,7 +257,7 @@ class GithubWebhook extends Base
$user = $this->user->getByUsername($issue['assignee']['login']);
$task = $this->taskFinder->getByReference($issue['number']);
if ($user && $task) {
if (! empty($user) && ! empty($task)) {
$event = array(
'project_id' => $this->project_id,
@@ -288,7 +288,7 @@ class GithubWebhook extends Base
{
$task = $this->taskFinder->getByReference($issue['number']);
if ($task) {
if (! empty($task)) {
$event = array(
'project_id' => $this->project_id,
@@ -320,7 +320,7 @@ class GithubWebhook extends Base
{
$task = $this->taskFinder->getByReference($issue['number']);
if ($task) {
if (! empty($task)) {
$event = array(
'project_id' => $this->project_id,
@@ -352,7 +352,7 @@ class GithubWebhook extends Base
{
$task = $this->taskFinder->getByReference($issue['number']);
if ($task) {
if (! empty($task)) {
$event = array(
'project_id' => $this->project_id,

4
app/Integration/GitlabWebhook.php
View File

@@ -122,7 +122,7 @@ class GitlabWebhook extends Base
$task = $this->taskFinder->getById($task_id);
if (! $task) {
if (empty($task)) {
return false;
}
@@ -193,7 +193,7 @@ class GitlabWebhook extends Base
{
$task = $this->taskFinder->getByReference($issue['id']);
if ($task) {
if (! empty($task)) {
$event = array(
'project_id' => $this->project_id,
'task_id' => $task['id'],

2
app/Integration/Hipchat.php
View File

@@ -17,7 +17,7 @@ class Hipchat extends Base
* @param integer $project_id Project id
* @param integer $task_id Task id
* @param string $event_name Event name
* @param array $data Event data
* @param array $event Event data
*/
public function notify($project_id, $task_id, $event_name, array $event)
{

2
app/Integration/SlackWebhook.php
View File

@@ -17,7 +17,7 @@ class SlackWebhook extends Base
* @param integer $project_id Project id
* @param integer $task_id Task id
* @param string $event_name Event name
* @param array $data Event data
* @param array $event Event data
*/
public function notify($project_id, $task_id, $event_name, array $event)
{