Various fixes for PHPAnalyzer

2015-04-03 18:32:51 -04:00
parent 91a5ec0885
commit 5a29cccc95
30 changed files with 48 additions and 38 deletions
--- a/app/Integration/GitlabWebhook.php
+++ b/app/Integration/GitlabWebhook.php
@@ -122,7 +122,7 @@ class GitlabWebhook extends Base

        $task = $this->taskFinder->getById($task_id);

-        if (! $task) {
+        if (empty($task)) {
            return false;
        }

@@ -193,7 +193,7 @@ class GitlabWebhook extends Base
    {
        $task = $this->taskFinder->getByReference($issue['id']);

-        if ($task) {
+        if (! empty($task)) {
            $event = array(
                'project_id' => $this->project_id,
                'task_id' => $task['id'],