AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove arguments of beforeAction() method

Browse Source
This commit is contained in:
Frederic Guillot
2015-12-30 14:54:54 +01:00
parent 019d83f3fc
commit 5b45a082d9
2 changed files with 16 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
app/Controller/Base.php
View File

@@ -17,18 +17,18 @@ abstract class Base extends \Kanboard\Core\Base
* *
* @access public * @access public
*/ */
public function beforeAction($controller, $action) public function beforeAction()
{ {
$this->sessionManager->open(); $this->sessionManager->open();
$this->dispatcher->dispatch('app.bootstrap'); $this->dispatcher->dispatch('app.bootstrap');
$this->sendHeaders($action); $this->sendHeaders();
$this->authenticationManager->checkCurrentSession(); $this->authenticationManager->checkCurrentSession();
if (! $this->applicationAuthorization->isAllowed($controller, $action, Role::APP_PUBLIC)) { if (! $this->applicationAuthorization->isAllowed($this->router->getController(), $this->router->getAction(), Role::APP_PUBLIC)) {
$this->handleAuthentication(); $this->handleAuthentication();
$this->handlePostAuthentication($controller, $action); $this->handlePostAuthentication();
$this->checkApplicationAuthorization($controller, $action); $this->checkApplicationAuthorization();
$this->checkProjectAuthorization($controller, $action); $this->checkProjectAuthorization();
} }
} }
@@ -37,7 +37,7 @@ abstract class Base extends \Kanboard\Core\Base
* *
* @access private * @access private
*/ */
private function sendHeaders($action) private function sendHeaders()
{ {
// HTTP secure headers // HTTP secure headers
$this->response->csp($this->container['cspRules']); $this->response->csp($this->container['cspRules']);
@@ -45,7 +45,7 @@ abstract class Base extends \Kanboard\Core\Base
$this->response->xss(); $this->response->xss();
// Allow the public board iframe inclusion // Allow the public board iframe inclusion
if (ENABLE_XFRAME && $action !== 'readonly') { if (ENABLE_XFRAME && $this->router->getAction() !== 'readonly') {
$this->response->xframe(); $this->response->xframe();
} }
@@ -76,8 +76,10 @@ abstract class Base extends \Kanboard\Core\Base
* *
* @access private * @access private
*/ */
private function handlePostAuthentication($controller, $action) private function handlePostAuthentication()
{ {
$controller = strtolower($this->router->getController());
$action = strtolower($this->router->getAction());
$ignore = ($controller === 'twofactor' && in_array($action, array('code', 'check'))) || ($controller === 'auth' && $action === 'logout'); $ignore = ($controller === 'twofactor' && in_array($action, array('code', 'check'))) || ($controller === 'auth' && $action === 'logout');
if ($ignore === false && $this->userSession->hasPostAuthentication() && ! $this->userSession->isPostAuthenticationValidated()) { if ($ignore === false && $this->userSession->hasPostAuthentication() && ! $this->userSession->isPostAuthenticationValidated()) {
@@ -94,9 +96,9 @@ abstract class Base extends \Kanboard\Core\Base
* *
* @access private * @access private
*/ */
private function checkApplicationAuthorization($controller, $action) private function checkApplicationAuthorization()
{ {
if (! $this->helper->user->hasAccess($controller, $action)) { if (! $this->helper->user->hasAccess($this->router->getController(), $this->router->getAction())) {
$this->forbidden(); $this->forbidden();
} }
} }
@@ -106,7 +108,7 @@ abstract class Base extends \Kanboard\Core\Base
* *
* @access private * @access private
*/ */
private function checkProjectAuthorization($controller, $action) private function checkProjectAuthorization()
{ {
$project_id = $this->request->getIntegerParam('project_id'); $project_id = $this->request->getIntegerParam('project_id');
$task_id = $this->request->getIntegerParam('task_id'); $task_id = $this->request->getIntegerParam('task_id');
@@ -116,7 +118,7 @@ abstract class Base extends \Kanboard\Core\Base
$project_id = $this->taskFinder->getProjectId($task_id); $project_id = $this->taskFinder->getProjectId($task_id);
} }
if ($project_id > 0 && ! $this->helper->user->hasProjectAccess($controller, $action, $project_id)) { if ($project_id > 0 && ! $this->helper->user->hasProjectAccess($this->router->getController(), $this->router->getAction(), $project_id)) {
$this->forbidden(); $this->forbidden();
} }
} }

2
app/Core/Http/Router.php
View File

@@ -147,7 +147,7 @@ class Router extends Base
} }
$instance = new $class($this->container); $instance = new $class($this->container);
$instance->beforeAction($this->controller, $this->action); $instance->beforeAction();
$instance->{$this->action}(); $instance->{$this->action}();
return $instance; return $instance;
} }