AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add external links for tasks with plugin api

Browse Source
This commit is contained in:
Frederic Guillot
2016-01-30 20:38:20 -05:00
parent ec66a779c9
commit 5c92f46786
81 changed files with 2544 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

120
tests/units/Core/ExternalLink/ExternalLinkManagerTest.php Normal file
View File

@@ -0,0 +1,120 @@
<?php
require_once __DIR__.'/../../Base.php';
use Kanboard\Core\ExternalLink\ExternalLinkManager;
use Kanboard\ExternalLink\WebLinkProvider;
use Kanboard\ExternalLink\AttachmentLinkProvider;
class ExternalLinkManagerTest extends Base
{
public function testRegister()
{
$externalLinkManager = new ExternalLinkManager($this->container);
$webLinkProvider = new WebLinkProvider($this->container);
$attachmentLinkProvider = new AttachmentLinkProvider($this->container);
$externalLinkManager->register($webLinkProvider);
$externalLinkManager->register($attachmentLinkProvider);
$this->assertInstanceOf(get_class($webLinkProvider), $externalLinkManager->getProvider($webLinkProvider->getType()));
$this->assertInstanceOf(get_class($attachmentLinkProvider), $externalLinkManager->getProvider($attachmentLinkProvider->getType()));
}
public function testGetProviderNotFound()
{
$externalLinkManager = new ExternalLinkManager($this->container);
$this->setExpectedException('\Kanboard\Core\ExternalLink\ExternalLinkProviderNotFound');
$externalLinkManager->getProvider('not found');
}
public function testGetTypes()
{
$externalLinkManager = new ExternalLinkManager($this->container);
$webLinkProvider = new WebLinkProvider($this->container);
$attachmentLinkProvider = new AttachmentLinkProvider($this->container);
$this->assertEquals(array(ExternalLinkManager::TYPE_AUTO => 'Auto'), $externalLinkManager->getTypes());
$externalLinkManager->register($webLinkProvider);
$externalLinkManager->register($attachmentLinkProvider);
$this->assertEquals(
array(ExternalLinkManager::TYPE_AUTO => 'Auto', 'attachment' => 'Attachment', 'weblink' => 'Web Link'),
$externalLinkManager->getTypes()
);
}
public function testGetDependencyLabel()
{
$externalLinkManager = new ExternalLinkManager($this->container);
$webLinkProvider = new WebLinkProvider($this->container);
$attachmentLinkProvider = new AttachmentLinkProvider($this->container);
$externalLinkManager->register($webLinkProvider);
$externalLinkManager->register($attachmentLinkProvider);
$this->assertSame('Related', $externalLinkManager->getDependencyLabel($webLinkProvider->getType(), 'related'));
$this->assertSame('custom', $externalLinkManager->getDependencyLabel($webLinkProvider->getType(), 'custom'));
}
public function testFindProviderNotFound()
{
$externalLinkManager = new ExternalLinkManager($this->container);
$webLinkProvider = new WebLinkProvider($this->container);
$attachmentLinkProvider = new AttachmentLinkProvider($this->container);
$externalLinkManager->register($webLinkProvider);
$externalLinkManager->register($attachmentLinkProvider);
$this->setExpectedException('\Kanboard\Core\ExternalLink\ExternalLinkProviderNotFound');
$externalLinkManager->find();
}
public function testFindProvider()
{
$externalLinkManager = new ExternalLinkManager($this->container);
$webLinkProvider = new WebLinkProvider($this->container);
$attachmentLinkProvider = new AttachmentLinkProvider($this->container);
$externalLinkManager->register($webLinkProvider);
$externalLinkManager->register($attachmentLinkProvider);
$externalLinkManager->setUserInput(array('text' => 'https://google.com/', 'type' => ExternalLinkManager::TYPE_AUTO));
$this->assertSame($webLinkProvider, $externalLinkManager->find());
$externalLinkManager->setUserInput(array('text' => 'https://google.com/file.pdf', 'type' => ExternalLinkManager::TYPE_AUTO));
$this->assertSame($attachmentLinkProvider, $externalLinkManager->find());
}
public function testFindProviderWithSelectedType()
{
$externalLinkManager = new ExternalLinkManager($this->container);
$webLinkProvider = new WebLinkProvider($this->container);
$attachmentLinkProvider = new AttachmentLinkProvider($this->container);
$externalLinkManager->register($webLinkProvider);
$externalLinkManager->register($attachmentLinkProvider);
$externalLinkManager->setUserInput(array('text' => 'https://google.com/', 'type' => $webLinkProvider->getType()));
$this->assertSame($webLinkProvider, $externalLinkManager->find());
$externalLinkManager->setUserInput(array('text' => 'https://google.com/file.pdf', 'type' => $attachmentLinkProvider->getType()));
$this->assertSame($attachmentLinkProvider, $externalLinkManager->find());
}
public function testFindProviderWithSelectedTypeNotFound()
{
$externalLinkManager = new ExternalLinkManager($this->container);
$webLinkProvider = new WebLinkProvider($this->container);
$attachmentLinkProvider = new AttachmentLinkProvider($this->container);
$externalLinkManager->register($webLinkProvider);
$externalLinkManager->register($attachmentLinkProvider);
$this->setExpectedException('\Kanboard\Core\ExternalLink\ExternalLinkProviderNotFound');
$externalLinkManager->setUserInput(array('text' => 'https://google.com/', 'type' => 'not found'));
$externalLinkManager->find();
}
}

64
tests/units/ExternalLink/AttachmentLinkProviderTest.php Normal file
View File

@@ -0,0 +1,64 @@
<?php
require_once __DIR__.'/../Base.php';
use Kanboard\ExternalLink\AttachmentLinkProvider;
class AttachmentLinkProviderTest extends Base
{
public function testGetName()
{
$attachmentLinkProvider = new AttachmentLinkProvider($this->container);
$this->assertEquals('Attachment', $attachmentLinkProvider->getName());
}
public function testGetType()
{
$attachmentLinkProvider = new AttachmentLinkProvider($this->container);
$this->assertEquals('attachment', $attachmentLinkProvider->getType());
}
public function testGetDependencies()
{
$attachmentLinkProvider = new AttachmentLinkProvider($this->container);
$this->assertEquals(array('related' => 'Related'), $attachmentLinkProvider->getDependencies());
}
public function testMatch()
{
$attachmentLinkProvider = new AttachmentLinkProvider($this->container);
$attachmentLinkProvider->setUserTextInput('http://kanboard.net/FILE.DOC');
$this->assertTrue($attachmentLinkProvider->match());
$attachmentLinkProvider->setUserTextInput('http://kanboard.net/folder/document.PDF');
$this->assertTrue($attachmentLinkProvider->match());
$attachmentLinkProvider->setUserTextInput('http://kanboard.net/archive.zip');
$this->assertTrue($attachmentLinkProvider->match());
$attachmentLinkProvider->setUserTextInput(' https://kanboard.net/folder/archive.tar ');
$this->assertTrue($attachmentLinkProvider->match());
$attachmentLinkProvider->setUserTextInput('http:// invalid url');
$this->assertFalse($attachmentLinkProvider->match());
$attachmentLinkProvider->setUserTextInput('');
$this->assertFalse($attachmentLinkProvider->match());
$attachmentLinkProvider->setUserTextInput('http://kanboard.net/folder/document.html');
$this->assertFalse($attachmentLinkProvider->match());
$attachmentLinkProvider->setUserTextInput('http://kanboard.net/folder/DOC.HTML');
$this->assertFalse($attachmentLinkProvider->match());
$attachmentLinkProvider->setUserTextInput('http://kanboard.net/folder/document.do');
$this->assertFalse($attachmentLinkProvider->match());
}
public function testGetLink()
{
$attachmentLinkProvider = new AttachmentLinkProvider($this->container);
$this->assertInstanceOf('\Kanboard\ExternalLink\AttachmentLink', $attachmentLinkProvider->getLink());
}
}

18
tests/units/ExternalLink/AttachmentLinkTest.php Normal file
View File

@@ -0,0 +1,18 @@
<?php
require_once __DIR__.'/../Base.php';
use Kanboard\ExternalLink\AttachmentLink;
class AttachmentLinkTest extends Base
{
public function testGetTitleFromUrl()
{
$url = 'https://kanboard.net/folder/document.pdf';
$link = new AttachmentLink($this->container);
$link->setUrl($url);
$this->assertEquals($url, $link->getUrl());
$this->assertEquals('document.pdf', $link->getTitle());
}
}

52
tests/units/ExternalLink/WebLinkProviderTest.php Normal file
View File

@@ -0,0 +1,52 @@
<?php
require_once __DIR__.'/../Base.php';
use Kanboard\ExternalLink\WebLinkProvider;
class WebLinkProviderTest extends Base
{
public function testGetName()
{
$webLinkProvider = new WebLinkProvider($this->container);
$this->assertEquals('Web Link', $webLinkProvider->getName());
}
public function testGetType()
{
$webLinkProvider = new WebLinkProvider($this->container);
$this->assertEquals('weblink', $webLinkProvider->getType());
}
public function testGetDependencies()
{
$webLinkProvider = new WebLinkProvider($this->container);
$this->assertEquals(array('related' => 'Related'), $webLinkProvider->getDependencies());
}
public function testMatch()
{
$webLinkProvider = new WebLinkProvider($this->container);
$webLinkProvider->setUserTextInput('http://kanboard.net/');
$this->assertTrue($webLinkProvider->match());
$webLinkProvider->setUserTextInput('http://kanboard.net/mypage');
$this->assertTrue($webLinkProvider->match());
$webLinkProvider->setUserTextInput(' https://kanboard.net/ ');
$this->assertTrue($webLinkProvider->match());
$webLinkProvider->setUserTextInput('http:// invalid url');
$this->assertFalse($webLinkProvider->match());
$webLinkProvider->setUserTextInput('');
$this->assertFalse($webLinkProvider->match());
}
public function testGetLink()
{
$webLinkProvider = new WebLinkProvider($this->container);
$this->assertInstanceOf('\Kanboard\ExternalLink\WebLink', $webLinkProvider->getLink());
}
}

57
tests/units/ExternalLink/WebLinkTest.php Normal file
View File

@@ -0,0 +1,57 @@
<?php
require_once __DIR__.'/../Base.php';
use Kanboard\ExternalLink\WebLink;
class WebLinkTest extends Base
{
public function testGetTitleFromHtml()
{
$url = 'http://kanboard.net/something';
$title = 'My title';
$html = '<!DOCTYPE html><html><head><title> '.$title.' </title></head><body>Test</body></html>';
$this->container['httpClient'] = $this
->getMockBuilder('\Kanboard\Core\Http\Client')
->setConstructorArgs(array($this->container))
->setMethods(array('get'))
->getMock();
$webLink = new WebLink($this->container);
$webLink->setUrl($url);
$this->assertEquals($url, $webLink->getUrl());
$this->container['httpClient']
->expects($this->once())
->method('get')
->with($url)
->will($this->returnValue($html));
$this->assertEquals($title, $webLink->getTitle());
}
public function testGetTitleFromUrl()
{
$url = 'http://kanboard.net/something';
$html = '<!DOCTYPE html><html><head></head><body>Test</body></html>';
$this->container['httpClient'] = $this
->getMockBuilder('\Kanboard\Core\Http\Client')
->setConstructorArgs(array($this->container))
->setMethods(array('get'))
->getMock();
$webLink = new WebLink($this->container);
$webLink->setUrl($url);
$this->assertEquals($url, $webLink->getUrl());
$this->container['httpClient']
->expects($this->once())
->method('get')
->with($url)
->will($this->returnValue($html));
$this->assertEquals('kanboard.net/something', $webLink->getTitle());
}
}

167
tests/units/Model/TaskExternalLinkTest.php Normal file
View File

@@ -0,0 +1,167 @@
<?php
require_once __DIR__.'/../Base.php';
use Kanboard\Model\TaskCreation;
use Kanboard\Model\Project;
use Kanboard\Model\TaskExternalLink;
use Kanboard\Core\ExternalLink\ExternalLinkManager;
use Kanboard\ExternalLink\WebLinkProvider;
class TaskExternalLinkTest extends Base
{
public function testCreate()
{
$projectModel = new Project($this->container);
$taskCreationModel = new TaskCreation($this->container);
$taskExternalLinkModel = new TaskExternalLink($this->container);
$this->assertEquals(1, $projectModel->create(array('name' => 'Test')));
$this->assertEquals(1, $taskCreationModel->create(array('title' => 'Test', 'project_id' => 1)));
$this->assertEquals(1, $taskExternalLinkModel->create(array('task_id' => 1, 'id' => '', 'url' => 'http://kanboard.net/', 'title' => 'My website', 'link_type' => 'weblink', 'dependency' => 'related')));
$link = $taskExternalLinkModel->getById(1);
$this->assertNotEmpty($link);
$this->assertEquals('My website', $link['title']);
$this->assertEquals('http://kanboard.net/', $link['url']);
$this->assertEquals('related', $link['dependency']);
$this->assertEquals('weblink', $link['link_type']);
$this->assertEquals(0, $link['creator_id']);
$this->assertEquals(time(), $link['date_modification'], '', 2);
$this->assertEquals(time(), $link['date_creation'], '', 2);
}
public function testCreateWithUserSession()
{
$this->container['sessionStorage']->user = array('id' => 1);
$projectModel = new Project($this->container);
$taskCreationModel = new TaskCreation($this->container);
$taskExternalLinkModel = new TaskExternalLink($this->container);
$this->assertEquals(1, $projectModel->create(array('name' => 'Test')));
$this->assertEquals(1, $taskCreationModel->create(array('title' => 'Test', 'project_id' => 1)));
$this->assertEquals(1, $taskExternalLinkModel->create(array('task_id' => 1, 'id' => '', 'url' => 'http://kanboard.net/', 'title' => 'My website', 'link_type' => 'weblink', 'dependency' => 'related')));
$link = $taskExternalLinkModel->getById(1);
$this->assertNotEmpty($link);
$this->assertEquals('My website', $link['title']);
$this->assertEquals('http://kanboard.net/', $link['url']);
$this->assertEquals('related', $link['dependency']);
$this->assertEquals('weblink', $link['link_type']);
$this->assertEquals(1, $link['creator_id']);
$this->assertEquals(time(), $link['date_modification'], '', 2);
$this->assertEquals(time(), $link['date_creation'], '', 2);
}
public function testCreateWithNoType()
{
$projectModel = new Project($this->container);
$taskCreationModel = new TaskCreation($this->container);
$taskExternalLinkModel = new TaskExternalLink($this->container);
$this->assertEquals(1, $projectModel->create(array('name' => 'Test')));
$this->assertEquals(1, $taskCreationModel->create(array('title' => 'Test', 'project_id' => 1)));
$this->assertFalse($taskExternalLinkModel->create(array('task_id' => 1, 'id' => '', 'url' => 'http://kanboard.net/', 'title' => 'My website', 'dependency' => 'related')));
}
public function testCreateWithNoDependency()
{
$projectModel = new Project($this->container);
$taskCreationModel = new TaskCreation($this->container);
$taskExternalLinkModel = new TaskExternalLink($this->container);
$this->assertEquals(1, $projectModel->create(array('name' => 'Test')));
$this->assertEquals(1, $taskCreationModel->create(array('title' => 'Test', 'project_id' => 1)));
$this->assertFalse($taskExternalLinkModel->create(array('task_id' => 1, 'id' => '', 'url' => 'http://kanboard.net/', 'title' => 'My website', 'link_type' => 'test')));
}
public function testCreateWithNoTitle()
{
$projectModel = new Project($this->container);
$taskCreationModel = new TaskCreation($this->container);
$taskExternalLinkModel = new TaskExternalLink($this->container);
$this->assertEquals(1, $projectModel->create(array('name' => 'Test')));
$this->assertEquals(1, $taskCreationModel->create(array('title' => 'Test', 'project_id' => 1)));
$this->assertFalse($taskExternalLinkModel->create(array('task_id' => 1, 'id' => '', 'url' => 'http://kanboard.net/', 'link_type' => 'test', 'dependency' => 'test')));
}
public function testCreateWithNoUrl()
{
$projectModel = new Project($this->container);
$taskCreationModel = new TaskCreation($this->container);
$taskExternalLinkModel = new TaskExternalLink($this->container);
$this->assertEquals(1, $projectModel->create(array('name' => 'Test')));
$this->assertEquals(1, $taskCreationModel->create(array('title' => 'Test', 'project_id' => 1)));
$this->assertFalse($taskExternalLinkModel->create(array('task_id' => 1, 'id' => '', 'title' => 'test', 'link_type' => 'test', 'dependency' => 'test')));
}
public function testModification()
{
$projectModel = new Project($this->container);
$taskCreationModel = new TaskCreation($this->container);
$taskExternalLinkModel = new TaskExternalLink($this->container);
$this->assertEquals(1, $projectModel->create(array('name' => 'Test')));
$this->assertEquals(1, $taskCreationModel->create(array('title' => 'Test', 'project_id' => 1)));
$this->assertEquals(1, $taskExternalLinkModel->create(array('task_id' => 1, 'id' => '', 'url' => 'http://kanboard.net/', 'title' => 'My website', 'link_type' => 'weblink', 'dependency' => 'related')));
sleep(1);
$this->assertTrue($taskExternalLinkModel->update(array('id' => 1, 'url' => 'https://kanboard.net/')));
$link = $taskExternalLinkModel->getById(1);
$this->assertNotEmpty($link);
$this->assertEquals('https://kanboard.net/', $link['url']);
$this->assertEquals(time(), $link['date_modification'], '', 2);
}
public function testRemove()
{
$projectModel = new Project($this->container);
$taskCreationModel = new TaskCreation($this->container);
$taskExternalLinkModel = new TaskExternalLink($this->container);
$this->assertEquals(1, $projectModel->create(array('name' => 'Test')));
$this->assertEquals(1, $taskCreationModel->create(array('title' => 'Test', 'project_id' => 1)));
$this->assertEquals(1, $taskExternalLinkModel->create(array('task_id' => 1, 'id' => '', 'url' => 'http://kanboard.net/', 'title' => 'My website', 'link_type' => 'weblink', 'dependency' => 'related')));
$this->assertTrue($taskExternalLinkModel->remove(1));
$this->assertFalse($taskExternalLinkModel->remove(1));
$this->assertEmpty($taskExternalLinkModel->getById(1));
}
public function testGetAll()
{
$this->container['sessionStorage']->user = array('id' => 1);
$this->container['externalLinkManager'] = new ExternalLinkManager($this->container);
$projectModel = new Project($this->container);
$taskCreationModel = new TaskCreation($this->container);
$taskExternalLinkModel = new TaskExternalLink($this->container);
$webLinkProvider = new WebLinkProvider($this->container);
$this->container['externalLinkManager']->register($webLinkProvider);
$this->assertEquals(1, $projectModel->create(array('name' => 'Test')));
$this->assertEquals(1, $taskCreationModel->create(array('title' => 'Test', 'project_id' => 1)));
$this->assertEquals(1, $taskExternalLinkModel->create(array('task_id' => 1, 'url' => 'https://miniflux.net/', 'title' => 'MX', 'link_type' => 'weblink', 'dependency' => 'related')));
$this->assertEquals(2, $taskExternalLinkModel->create(array('task_id' => 1, 'url' => 'http://kanboard.net/', 'title' => 'KB', 'link_type' => 'weblink', 'dependency' => 'related')));
$links = $taskExternalLinkModel->getAll(1);
$this->assertCount(2, $links);
$this->assertEquals('KB', $links[0]['title']);
$this->assertEquals('MX', $links[1]['title']);
$this->assertEquals('Web Link', $links[0]['type']);
$this->assertEquals('Web Link', $links[1]['type']);
$this->assertEquals('Related', $links[0]['dependency_label']);
$this->assertEquals('Related', $links[1]['dependency_label']);
$this->assertEquals('admin', $links[0]['creator_username']);
$this->assertEquals('admin', $links[1]['creator_username']);
$this->assertEquals('', $links[0]['creator_name']);
$this->assertEquals('', $links[1]['creator_name']);
}
}

63
tests/units/Validator/ExternalLinkValidatorTest.php Normal file
View File

@@ -0,0 +1,63 @@
<?php
require_once __DIR__.'/../Base.php';
use Kanboard\Validator\ExternalLinkValidator;
class ExternalLinkValidatorTest extends Base
{
public function testValidateCreation()
{
$validator = new ExternalLinkValidator($this->container);
$result = $validator->validateCreation(array('url' => 'http://somewhere', 'task_id' => 1, 'title' => 'Title', 'link_type' => 'weblink', 'dependency' => 'related'));
$this->assertTrue($result[0]);
$result = $validator->validateCreation(array('url' => 'http://somewhere', 'task_id' => 'abc', 'title' => 'Title', 'link_type' => 'weblink', 'dependency' => 'related'));
$this->assertFalse($result[0]);
$result = $validator->validateCreation(array('url' => 'http://somewhere', 'task_id' => 1, 'title' => 'Title', 'link_type' => 'weblink'));
$this->assertFalse($result[0]);
$result = $validator->validateCreation(array('url' => 'http://somewhere', 'task_id' => 1, 'title' => 'Title', 'dependency' => 'related'));
$this->assertFalse($result[0]);
$result = $validator->validateCreation(array('url' => 'http://somewhere', 'task_id' => 1, 'link_type' => 'weblink', 'dependency' => 'related'));
$this->assertFalse($result[0]);
$result = $validator->validateCreation(array('url' => 'http://somewhere', 'title' => 'Title', 'link_type' => 'weblink', 'dependency' => 'related'));
$this->assertFalse($result[0]);
$result = $validator->validateCreation(array('task_id' => 1, 'title' => 'Title', 'link_type' => 'weblink', 'dependency' => 'related'));
$this->assertFalse($result[0]);
}
public function testValidateModification()
{
$validator = new ExternalLinkValidator($this->container);
$result = $validator->validateModification(array('id' => 1, 'url' => 'http://somewhere', 'task_id' => 1, 'title' => 'Title', 'link_type' => 'weblink', 'dependency' => 'related'));
$this->assertTrue($result[0]);
$result = $validator->validateModification(array('id' => 1, 'url' => 'http://somewhere', 'task_id' => 'abc', 'title' => 'Title', 'link_type' => 'weblink', 'dependency' => 'related'));
$this->assertFalse($result[0]);
$result = $validator->validateModification(array('id' => 1, 'url' => 'http://somewhere', 'task_id' => 1, 'title' => 'Title', 'link_type' => 'weblink'));
$this->assertFalse($result[0]);
$result = $validator->validateModification(array('id' => 1, 'url' => 'http://somewhere', 'task_id' => 1, 'title' => 'Title', 'dependency' => 'related'));
$this->assertFalse($result[0]);
$result = $validator->validateModification(array('id' => 1, 'url' => 'http://somewhere', 'task_id' => 1, 'link_type' => 'weblink', 'dependency' => 'related'));
$this->assertFalse($result[0]);
$result = $validator->validateModification(array('id' => 1, 'url' => 'http://somewhere', 'title' => 'Title', 'link_type' => 'weblink', 'dependency' => 'related'));
$this->assertFalse($result[0]);
$result = $validator->validateModification(array('id' => 1, 'task_id' => 1, 'title' => 'Title', 'link_type' => 'weblink', 'dependency' => 'related'));
$this->assertFalse($result[0]);
$result = $validator->validateModification(array('url' => 'http://somewhere', 'task_id' => 1, 'title' => 'Title', 'link_type' => 'weblink', 'dependency' => 'related'));
$this->assertFalse($result[0]);
}
}