Improve LDAP user group membership synchronization

This commit is contained in:
Frederic Guillot
2016-05-03 22:51:48 -04:00
parent 38e9f9928e
commit 60c8867fee
4 changed files with 105 additions and 9 deletions

View File

@@ -8,7 +8,7 @@ use Kanboard\Model\GroupMember;
class GroupSyncTest extends Base
{
public function testSynchronize()
public function testAddGroups()
{
$group = new Group($this->container);
$groupMember = new GroupMember($this->container);
@@ -27,4 +27,63 @@ class GroupSyncTest extends Base
$this->assertTrue($groupMember->isMember(1, 1));
$this->assertTrue($groupMember->isMember(2, 1));
}
public function testRemoveGroups()
{
$group = new Group($this->container);
$groupMember = new GroupMember($this->container);
$groupSync = new GroupSync($this->container);
$this->assertEquals(1, $group->create('My Group 1', 'externalId1'));
$this->assertEquals(2, $group->create('My Group 2', 'externalId2'));
$this->assertTrue($groupMember->addUser(1, 1));
$this->assertTrue($groupMember->isMember(1, 1));
$this->assertFalse($groupMember->isMember(2, 1));
$groupSync->synchronize(1, array('externalId3'));
$this->assertFalse($groupMember->isMember(1, 1));
$this->assertFalse($groupMember->isMember(2, 1));
}
public function testBoth()
{
$group = new Group($this->container);
$groupMember = new GroupMember($this->container);
$groupSync = new GroupSync($this->container);
$this->assertEquals(1, $group->create('My Group 1', 'externalId1'));
$this->assertEquals(2, $group->create('My Group 2', 'externalId2'));
$this->assertEquals(3, $group->create('My Group 3', 'externalId3'));
$this->assertTrue($groupMember->addUser(1, 1));
$this->assertTrue($groupMember->addUser(2, 1));
$this->assertTrue($groupMember->isMember(1, 1));
$this->assertTrue($groupMember->isMember(2, 1));
$this->assertFalse($groupMember->isMember(3, 1));
$groupSync->synchronize(1, array('externalId1', 'externalId3'));
$this->assertTrue($groupMember->isMember(1, 1));
$this->assertFalse($groupMember->isMember(2, 1));
$this->assertTrue($groupMember->isMember(3, 1));
}
public function testThatInternalGroupsAreNotTouched()
{
$group = new Group($this->container);
$groupMember = new GroupMember($this->container);
$groupSync = new GroupSync($this->container);
$this->assertEquals(1, $group->create('My Group 1'));
$this->assertTrue($groupMember->addUser(1, 1));
$this->assertTrue($groupMember->isMember(1, 1));
$groupSync->synchronize(1, array('externalId3'));
$this->assertTrue($groupMember->isMember(1, 1));
}
}