Add aria-label to project select role without label
This commit is contained in:
committed by
Frédéric Guillot
parent
87c123bba4
commit
6231c159b8
@@ -21,6 +21,7 @@
|
|||||||
'roles' => $roles,
|
'roles' => $roles,
|
||||||
'role' => $group['role'],
|
'role' => $group['role'],
|
||||||
'id' => $group['id'],
|
'id' => $group['id'],
|
||||||
|
'ariaLabel' => t('Role'),
|
||||||
'url' => $this->url->to('ProjectPermissionController', 'changeGroupRole', array('project_id' => $project['id'])),
|
'url' => $this->url->to('ProjectPermissionController', 'changeGroupRole', array('project_id' => $project['id'])),
|
||||||
)) ?>
|
)) ?>
|
||||||
</td>
|
</td>
|
||||||
|
|||||||
@@ -17,6 +17,7 @@
|
|||||||
'roles' => $roles,
|
'roles' => $roles,
|
||||||
'role' => $user['role'],
|
'role' => $user['role'],
|
||||||
'id' => $user['id'],
|
'id' => $user['id'],
|
||||||
|
'ariaLabel' => t('Role'),
|
||||||
'url' => $this->url->to('ProjectPermissionController', 'changeUserRole', array('project_id' => $project['id'])),
|
'url' => $this->url->to('ProjectPermissionController', 'changeUserRole', array('project_id' => $project['id'])),
|
||||||
)) ?>
|
)) ?>
|
||||||
</td>
|
</td>
|
||||||
|
|||||||
@@ -33,6 +33,14 @@ KB.component('project-select-role', function (containerElement, options) {
|
|||||||
containerElement.appendChild(componentElement);
|
containerElement.appendChild(componentElement);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
function getAriaLabelValue() {
|
||||||
|
if (options.ariaLabel) {
|
||||||
|
return options.ariaLabel;
|
||||||
|
}
|
||||||
|
|
||||||
|
return '';
|
||||||
|
}
|
||||||
|
|
||||||
function buildComponentElement() {
|
function buildComponentElement() {
|
||||||
var roles = [];
|
var roles = [];
|
||||||
var container = KB.dom('div');
|
var container = KB.dom('div');
|
||||||
@@ -49,7 +57,7 @@ KB.component('project-select-role', function (containerElement, options) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
container.add(KB.dom('select').change(onChange).for('option', roles).build());
|
container.add(KB.dom('select').attr('aria-label', getAriaLabelValue()).change(onChange).for('option', roles).build());
|
||||||
|
|
||||||
if (isLoading) {
|
if (isLoading) {
|
||||||
container.text(' ');
|
container.text(' ');
|
||||||
|
|||||||
Reference in New Issue
Block a user