AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

TaskAssignColorOnDueDateAction: update task only when necessary

Browse Source
This commit is contained in:
Frederic Guillot
2017-05-12 15:35:29 -04:00
parent daf39ee16a
commit 630f4ee780
3 changed files with 30 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ChangeLog
View File

@@ -1,3 +1,10 @@
Version 1.0.44 (unreleased)
---------------------------
Improvements:
* Improve automated action TaskAssignColorOnDueDate to update task only when necessary
Version 1.0.43 (April 30, 2017) Version 1.0.43 (April 30, 2017)
------------------------------- -------------------------------

2
app/Action/TaskAssignColorOnDueDate.php
View File

@@ -74,7 +74,7 @@ class TaskAssignColorOnDueDate extends Base
$results = array(); $results = array();
foreach ($data['tasks'] as $task) { foreach ($data['tasks'] as $task) {
if ($task['date_due'] <= time() && $task['date_due'] > 0) { if ($task['date_due'] <= time() && $task['date_due'] > 0 && $task['color_id'] != $this->getParam('color_id')) {
$values = array( $values = array(
'id' => $task['id'], 'id' => $task['id'],
'color_id' => $this->getParam('color_id'), 'color_id' => $this->getParam('color_id'),

22
tests/units/Action/TaskAssignColorOnDueDateTest.php
View File

@@ -34,4 +34,26 @@ class TaskAssignColorOnDueDateTest extends Base
$this->assertEquals('red', $tasks[0]['color_id']); $this->assertEquals('red', $tasks[0]['color_id']);
$this->assertEquals('yellow', $tasks[1]['color_id']); $this->assertEquals('yellow', $tasks[1]['color_id']);
} }
public function testChangeColorOnlyWhenNecessary()
{
$projectModel = new ProjectModel($this->container);
$taskCreationModel = new TaskCreationModel($this->container);
$taskFinderModel = new TaskFinderModel($this->container);
$this->assertEquals(1, $projectModel->create(array('name' => 'test1')));
$this->assertEquals(1, $taskCreationModel->create(array('project_id' => 1, 'title' => 'test', 'date_due' => strtotime('-1 day'), 'color_id' => 'red')));
$tasks = $taskFinderModel->getAll(1);
$event = new TaskListEvent(array('tasks' => $tasks, 'project_id' => 1));
$action = new TaskAssignColorOnDueDate($this->container);
$action->setProjectId(1);
$action->setParam('color_id', 'red');
$this->assertFalse($action->execute($event, TaskModel::EVENT_DAILY_CRONJOB));
$tasks = $taskFinderModel->getAll(1);
$this->assertEquals('red', $tasks[0]['color_id']);
}
} }