Add unit test to remove metadata

ChangeLog

@@ -6,6 +6,7 @@ New features:
 - Added support of user mentions (@username)
 - Added report to compare working hours between open and closed tasks
 - Added the possiblity to define custom routes from plugins
+- Added new method to remove metadata
 
 Improvements:
 

app/Model/Metadata.php

@@ -106,16 +106,6 @@ abstract class Metadata extends Base
      */
     public function remove($entity_id, $name)
     {
-
+        return $this->db->table(static::TABLE)->eq($this->getEntityKey(), $entity_id)->eq('name', $name)->remove();
-	$this->db->startTransaction();
-
-        if (! $this->db->table(static::TABLE)->eq($this->getEntityKey(), $entity_id)->eq('name', $name)->remove()) {
-            $this->db->cancelTransaction();
-            return false;
-        }
-
-        $this->db->closeTransaction();
-
-        return true;
     }
 }

tests/units/Model/ProjectMetadataTest.php

@@ -30,6 +30,11 @@ class ProjectMetadataTest extends Base
 
         $this->assertEquals(array('key1' => 'value2'), $pm->getAll(1));
         $this->assertEquals(array('key1' => 'value1', 'key2' => 'value2'), $pm->getAll(2));
+
+        $this->assertTrue($pm->remove(2, 'key1'));
+        $this->assertFalse($pm->remove(2, 'key1'));
+
+        $this->assertEquals(array('key2' => 'value2'), $pm->getAll(2));
     }
 
     public function testAutomaticRemove()

tests/units/Model/TaskMetadataTest.php

@@ -33,5 +33,10 @@ class TaskMetadataTest extends Base
 
         $this->assertEquals(array('key1' => 'value2'), $tm->getAll(1));
         $this->assertEquals(array('key1' => 'value1', 'key2' => 'value2'), $tm->getAll(2));
+
+        $this->assertTrue($tm->remove(2, 'key1'));
+        $this->assertFalse($tm->remove(2, 'key1'));
+
+        $this->assertEquals(array('key2' => 'value2'), $tm->getAll(2));
     }
 }

tests/units/Model/UserMetadataTest.php

@@ -29,5 +29,10 @@ class UserMetadataTest extends Base
 
         $this->assertEquals(array('key1' => 'value2'), $m->getAll(1));
         $this->assertEquals(array('key1' => 'value1', 'key2' => 'value2'), $m->getAll(2));
+
+        $this->assertTrue($m->remove(2, 'key1'));
+        $this->assertFalse($m->remove(2, 'key1'));
+
+        $this->assertEquals(array('key2' => 'value2'), $m->getAll(2));
     }
 }