Allow closing modals by clicking on the background

Cherry-pick #4044

Fixes #4895
This commit is contained in:
Frédéric Guillot
2023-03-30 19:42:33 -07:00
committed by Frédéric Guillot
parent de7c1bf16b
commit 6ca955de1f
4 changed files with 15 additions and 15 deletions

View File

@@ -20,7 +20,7 @@
var url = KB.dom(baseElement).data('url');
if (url) {
KB.modal.open(url, 'medium', false);
KB.modal.open(url, 'medium', true);
}
}

View File

@@ -27,7 +27,7 @@ KB.keyboardShortcuts = function () {
KB.onKey('?', function () {
if (! KB.modal.isOpen()) {
KB.modal.open(KB.find('body').data('keyboardShortcutUrl'));
KB.modal.open(KB.find('body').data('keyboardShortcutUrl'), '', true);
}
});
@@ -62,7 +62,7 @@ KB.keyboardShortcuts = function () {
KB.onKey('n', function () {
if (! KB.modal.isOpen()) {
KB.modal.open(KB.find('#board').data('taskCreationUrl'), 'large', false);
KB.modal.open(KB.find('#board').data('taskCreationUrl'), 'large', true);
}
});
}
@@ -70,25 +70,25 @@ KB.keyboardShortcuts = function () {
if (KB.exists('#task-view')) {
KB.onKey('e', function () {
if (! KB.modal.isOpen()) {
KB.modal.open(KB.find('#task-view').data('editUrl'), 'large', false);
KB.modal.open(KB.find('#task-view').data('editUrl'), 'large', true);
}
});
KB.onKey('c', function () {
if (! KB.modal.isOpen()) {
KB.modal.open(KB.find('#task-view').data('commentUrl'), 'medium', false);
KB.modal.open(KB.find('#task-view').data('commentUrl'), 'medium', true);
}
});
KB.onKey('s', function () {
if (! KB.modal.isOpen()) {
KB.modal.open(KB.find('#task-view').data('subtaskUrl'), 'medium', false);
KB.modal.open(KB.find('#task-view').data('subtaskUrl'), 'medium', true);
}
});
KB.onKey('l', function () {
if (! KB.modal.isOpen()) {
KB.modal.open(KB.find('#task-view').data('internalLinkUrl'), 'medium', false);
KB.modal.open(KB.find('#task-view').data('internalLinkUrl'), 'medium', true);
}
});
}

View File

@@ -8,23 +8,23 @@
}
KB.onClick('.js-modal-large', function (e) {
KB.modal.open(getLink(e), 'large', false);
KB.modal.open(getLink(e), 'large', true);
});
KB.onClick('.js-modal-medium', function (e) {
if (KB.modal.isOpen()) {
KB.modal.replace(getLink(e));
} else {
KB.modal.open(getLink(e), 'medium', false);
KB.modal.open(getLink(e), 'medium', true);
}
});
KB.onClick('.js-modal-small', function (e) {
KB.modal.open(getLink(e), 'small', false);
KB.modal.open(getLink(e), 'small', true);
});
KB.onClick('.js-modal-confirm', function (e) {
KB.modal.open(getLink(e), 'small');
KB.modal.open(getLink(e), 'small', true);
});
KB.onClick('.js-modal-close', function () {