AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add comment creation form to the task summary page (pull-request #300)

Browse Source
This commit is contained in:
Frédéric Guillot
2014-10-07 11:27:46 -04:00
parent cfe69443b7
commit 86928e37bc
4 changed files with 23 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/Templates/comment_create.php
View File

@@ -6,12 +6,14 @@
<?= Helper\form_csrf() ?> <?= Helper\form_csrf() ?>
<?= Helper\form_hidden('task_id', $values) ?> <?= Helper\form_hidden('task_id', $values) ?>
<?= Helper\form_hidden('user_id', $values) ?> <?= Helper\form_hidden('user_id', $values) ?>
<?= Helper\form_textarea('comment', $values, $errors, array('autofocus', 'required', 'placeholder="'.t('Leave a comment').'"'), 'comment-textarea') ?><br/> <?= Helper\form_textarea('comment', $values, $errors, array(! isset($skip_cancel) ? 'autofocus' : '', 'required', 'placeholder="'.t('Leave a comment').'"'), 'comment-textarea') ?><br/>
<div class="form-help"><a href="http://kanboard.net/documentation/syntax-guide" target="_blank" rel="noreferrer"><?= t('Write your text in Markdown') ?></a></div> <div class="form-help"><a href="http://kanboard.net/documentation/syntax-guide" target="_blank" rel="noreferrer"><?= t('Write your text in Markdown') ?></a></div>
<div class="form-actions"> <div class="form-actions">
<input type="submit" value="<?= t('Save') ?>" class="btn btn-blue"/> <input type="submit" value="<?= t('Save') ?>" class="btn btn-blue"/>
<?= t('or') ?> <?php if (! isset($skip_cancel)): ?>
<a href="?controller=task&amp;action=show&amp;task_id=<?= $task['id'] ?>"><?= t('cancel') ?></a> <?= t('or') ?>
<a href="?controller=task&amp;action=show&amp;task_id=<?= $task['id'] ?>"><?= t('cancel') ?></a>
<?php endif ?>
</div> </div>
</form> </form>

12
app/Templates/task_comments.php
View File

@@ -11,5 +11,17 @@
'not_editable' => isset($not_editable) && $not_editable, 'not_editable' => isset($not_editable) && $not_editable,
)) ?> )) ?>
<?php endforeach ?> <?php endforeach ?>
<?php if (! isset($not_editable)): ?>
<?= Helper\template('comment_create', array(
'skip_cancel' => true,
'values' => array(
'user_id' => Helper\get_user_id(),
'task_id' => $task['id'],
),
'errors' => array(),
'task' => $task
)) ?>
<?php endif ?>
</div> </div>
<?php endif ?> <?php endif ?>

5
assets/css/app.css
View File

@@ -904,6 +904,11 @@ a.task-board-nobody {
max-width: 800px; max-width: 800px;
} }
#comments .comment-textarea {
height: 80px;
width: 500px;
}
/* subtasks */ /* subtasks */
.subtasks-table { .subtasks-table {
font-size: 0.85em; font-size: 0.85em;

1
docs/coding-standards.markdown
View File

@@ -7,6 +7,7 @@ PHP code
- Indentation: 4 spaces - Indentation: 4 spaces
- Line return: Unix => `\n` - Line return: Unix => `\n`
- Encoding: UTF-8 - Encoding: UTF-8
- Use only the opening tags `<?php` or `<?=` for templates, but **never** use `<?`
- Always write PHPdoc comments for methods and class properties - Always write PHPdoc comments for methods and class properties
- Coding style: Try to follow [PSR-1](http://www.php-fig.org/psr/psr-1/) and [PSR-2](http://www.php-fig.org/psr/psr-2/) otherwise follow the actual style. - Coding style: Try to follow [PSR-1](http://www.php-fig.org/psr/psr-1/) and [PSR-2](http://www.php-fig.org/psr/psr-2/) otherwise follow the actual style.