AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve automatic action to create comments based on commit messages

Browse Source
This commit is contained in:
Frederic Guillot
2015-06-20 20:55:50 -04:00
parent 7b947ebdbd
commit 98fd34bfe3
9 changed files with 139 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/Action/CommentCreation.php
View File

@@ -2,7 +2,9 @@
namespace Action;
use Integration\BitbucketWebhook;
use Integration\GithubWebhook;
use Integration\GitlabWebhook;
/**
* Create automatically a comment from a webhook
@@ -22,6 +24,9 @@ class CommentCreation extends Base
{
return array(
GithubWebhook::EVENT_ISSUE_COMMENT,
GithubWebhook::EVENT_COMMIT,
BitbucketWebhook::EVENT_COMMIT,
GitlabWebhook::EVENT_COMMIT,
);
}
@@ -45,8 +50,6 @@ class CommentCreation extends Base
public function getEventRequiredParameters()
{
return array(
'comment',
'user_id',
'task_id',
);
}
@@ -62,9 +65,9 @@ class CommentCreation extends Base
{
return (bool) $this->comment->create(array(
'reference' => isset($data['reference']) ? $data['reference'] : '',
'comment' => $data['comment'],
'comment' => empty($data['comment']) ? $data['commit_comment'] : $data['comment'],
'task_id' => $data['task_id'],
'user_id' => $data['user_id'],
'user_id' => empty($data['user_id']) ? 0 : $data['user_id'],
));
}
@@ -77,6 +80,6 @@ class CommentCreation extends Base
*/
public function hasRequiredCondition(array $data)
{
return true;
return ! empty($data['comment']) || ! empty($data['commit_comment']);
}
}