AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Define only what is allowed for column restrictions

Browse Source
This commit is contained in:
Frederic Guillot
2016-09-10 23:12:38 -04:00
parent 44f680cf2f
commit a0227cad69
12 changed files with 31 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/units/Helper/BoardHelperTest.php
View File

@@ -87,8 +87,12 @@ class BoardHelperTest extends Base
$this->assertTrue($projectUserRole->addUser(1, 2, 'Custom Role'));
$this->assertEquals(1, $taskCreationModel->create(array('project_id' => 1, 'title' => 'test', 'column_id' => 2)));
$this->assertEquals(2, $taskCreationModel->create(array('project_id' => 1, 'title' => 'test', 'column_id' => 3)));
$task = $taskFinderModel->getById(1);
$this->assertTrue($boardHelper->isDraggable($task));
$task = $taskFinderModel->getById(2);
$this->assertFalse($boardHelper->isDraggable($task));
}
}

5
tests/units/Model/ColumnMoveRestrictionModelTest.php
View File

@@ -132,8 +132,7 @@ class ColumnMoveRestrictionModelTest extends Base
$this->assertEquals(1, $columnMoveRestrictionModel->create(1, 1, 2, 3));
$this->assertEquals(2, $columnMoveRestrictionModel->create(1, 2, 3, 4));
$this->assertTrue($columnMoveRestrictionModel->isAllowed(1, 'Role D', 1, 2));
$this->assertTrue($columnMoveRestrictionModel->isAllowed(1, 'Role A', 1, 2));
$this->assertFalse($columnMoveRestrictionModel->isAllowed(1, 'Role A', 2, 3));
$this->assertFalse($columnMoveRestrictionModel->isAllowed(1, 'Role A', 1, 2));
$this->assertTrue($columnMoveRestrictionModel->isAllowed(1, 'Role A', 2, 3));
}
}