AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Replace switch/case by a mapping list

Browse Source
This commit is contained in:
Frederic Guillot
2015-09-20 22:46:18 -04:00
parent 38ea489ec8
commit aeb79f7de5
1 changed files with 24 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

65
app/Model/TaskFilter.php
View File

@@ -10,6 +10,28 @@ namespace Model;
*/ */
class TaskFilter extends Base class TaskFilter extends Base
{ {
/**
* Filters mapping
*
* @access private
* @var array
*/
private $filters = array(
'T_ASSIGNEE' => 'filterByAssignee',
'T_COLOR' => 'filterByColors',
'T_DUE' => 'filterByDueDate',
'T_UPDATED' => 'filterByModificationDate',
'T_CREATED' => 'filterByCreationDate',
'T_TITLE' => 'filterByTitle',
'T_STATUS' => 'filterByStatusName',
'T_DESCRIPTION' => 'filterByDescription',
'T_CATEGORY' => 'filterByCategoryName',
'T_PROJECT' => 'filterByProjectName',
'T_COLUMN' => 'filterByColumnName',
'T_REFERENCE' => 'filterByReference',
'T_SWIMLANE' => 'filterBySwimlaneName',
);
/** /**
* Query * Query
* *
@@ -35,47 +57,8 @@ class TaskFilter extends Base
} }
foreach ($tree as $filter => $value) { foreach ($tree as $filter => $value) {
switch ($filter) { $method = $this->filters[$filter];
case 'T_ASSIGNEE': $this->$method($value);
$this->filterByAssignee($value);
break;
case 'T_COLOR':
$this->filterByColors($value);
break;
case 'T_DUE':
$this->filterByDueDate($value);
break;
case 'T_UPDATED':
$this->filterByModificationDate($value);
break;
case 'T_CREATED':
$this->filterByCreationDate($value);
break;
case 'T_TITLE':
$this->filterByTitle($value);
break;
case 'T_STATUS':
$this->filterByStatusName($value);
break;
case 'T_DESCRIPTION':
$this->filterByDescription($value);
break;
case 'T_CATEGORY':
$this->filterByCategoryName($value);
break;
case 'T_PROJECT':
$this->filterByProjectName($value);
break;
case 'T_COLUMN':
$this->filterByColumnName($value);
break;
case 'T_REFERENCE':
$this->filterByReference($value);
break;
case 'T_SWIMLANE':
$this->filterBySwimlaneName($value);
break;
}
} }
return $this; return $this;