AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Always trim the username before saving changes in the database

Browse Source 
Fixes #4742
This commit is contained in:
Frédéric Guillot
2023-02-12 18:17:23 -08:00
committed by Frédéric Guillot
parent 5f3225bddc
commit bd8bcfbc37
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Model/UserModel.php
View File

@@ -261,6 +261,10 @@ class UserModel extends Base
} }
} }
if (isset($values['username'])) {
$values['username'] = trim($values['username']);
}
$this->helper->model->removeFields($values, array('confirmation', 'current_password')); $this->helper->model->removeFields($values, array('confirmation', 'current_password'));
$this->helper->model->resetFields($values, array('is_ldap_user', 'disable_login_form')); $this->helper->model->resetFields($values, array('is_ldap_user', 'disable_login_form'));
$this->helper->model->convertNullFields($values, array('gitlab_id')); $this->helper->model->convertNullFields($values, array('gitlab_id'));

9
tests/units/Model/UserModelTest.php
View File

@@ -394,4 +394,13 @@ class UserModelTest extends Base
$project = $projectModel->getById(1); $project = $projectModel->getById(1);
$this->assertEquals(0, $project['is_active']); $this->assertEquals(0, $project['is_active']);
} }
public function testTrimUsername()
{
$userModel = new UserModel($this->container);
$this->assertNotFalse($userModel->create(array('username' => 'test ')));
$this->assertNotEmpty($userModel->getByUsername('test'));
$this->assertEmpty($userModel->getByUsername('test '));
}
} }