Restrict task complexity to a specific range to avoid integer overflow

2016-10-08 09:58:11 -04:00
parent 1466afb771
commit c2f1cc8f74
37 changed files with 179 additions and 132 deletions
--- a/app/Locale/bs_BA/translations.php
+++ b/app/Locale/bs_BA/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/cs_CZ/translations.php
+++ b/app/Locale/cs_CZ/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/da_DK/translations.php
+++ b/app/Locale/da_DK/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/de_DE/translations.php
+++ b/app/Locale/de_DE/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/el_GR/translations.php
+++ b/app/Locale/el_GR/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/es_ES/translations.php
+++ b/app/Locale/es_ES/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/fi_FI/translations.php
+++ b/app/Locale/fi_FI/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/fr_FR/translations.php
+++ b/app/Locale/fr_FR/translations.php
@@ -1277,4 +1277,5 @@ return array(
    'Duplicate to multiple projects' => 'Dupliquer vers plusieurs projets',
    'This field is required' => 'Ce champ est requis',
    'Moving a task is not permitted' => 'Déplaçer une tâche n\'est pas autorisé',
+    'This value must be in the range %d to %d' => 'Cette valeur doit être définie entre %d et %d',
 );
--- a/app/Locale/hu_HU/translations.php
+++ b/app/Locale/hu_HU/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/id_ID/translations.php
+++ b/app/Locale/id_ID/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/it_IT/translations.php
+++ b/app/Locale/it_IT/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/ja_JP/translations.php
+++ b/app/Locale/ja_JP/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/ko_KR/translations.php
+++ b/app/Locale/ko_KR/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/my_MY/translations.php
+++ b/app/Locale/my_MY/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/nb_NO/translations.php
+++ b/app/Locale/nb_NO/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/nl_NL/translations.php
+++ b/app/Locale/nl_NL/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/pl_PL/translations.php
+++ b/app/Locale/pl_PL/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/pt_BR/translations.php
+++ b/app/Locale/pt_BR/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/pt_PT/translations.php
+++ b/app/Locale/pt_PT/translations.php
@@ -1276,4 +1276,5 @@ return array(
    'Duplicate to multiple projects' => 'Duplicar para vários projetos',
    'This field is required' => 'Este campo é obrigatório',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/ru_RU/translations.php
+++ b/app/Locale/ru_RU/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/sr_Latn_RS/translations.php
+++ b/app/Locale/sr_Latn_RS/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/sv_SE/translations.php
+++ b/app/Locale/sv_SE/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/th_TH/translations.php
+++ b/app/Locale/th_TH/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/tr_TR/translations.php
+++ b/app/Locale/tr_TR/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Locale/zh_CN/translations.php
+++ b/app/Locale/zh_CN/translations.php
@@ -1276,4 +1276,5 @@ return array(
    // 'Duplicate to multiple projects' => '',
    // 'This field is required' => '',
    // 'Moving a task is not permitted' => '',
+    // 'This value must be in the range %d to %d' => '',
 );
--- a/app/Validator/TaskValidator.php
+++ b/app/Validator/TaskValidator.php
@@ -28,6 +28,7 @@ class TaskValidator extends BaseValidator
            new Validators\Integer('owner_id', t('This value must be an integer')),
            new Validators\Integer('creator_id', t('This value must be an integer')),
            new Validators\Integer('score', t('This value must be an integer')),
+            new Validators\Range('score', t('This value must be in the range %d to %d', -2147483647, 2147483647), -2147483647, 2147483647),
            new Validators\Integer('category_id', t('This value must be an integer')),
            new Validators\Integer('swimlane_id', t('This value must be an integer')),
            new Validators\Integer('recurrence_child', t('This value must be an integer')),
@@ -95,27 +96,6 @@ class TaskValidator extends BaseValidator
        );
    }

-    /**
-     * Validate description creation
-     *
-     * @access public
-     * @param  array   $values           Form values
-     * @return array   $valid, $errors   [0] = Success or not, [1] = List of errors
-     */
-    public function validateDescriptionCreation(array $values)
-    {
-        $rules = array(
-            new Validators\Required('id', t('The id is required')),
-        );
-
-        $v = new Validator($values, array_merge($rules, $this->commonValidationRules()));
-
-        return array(
-            $v->execute(),
-            $v->getErrors()
-        );
-    }
-
    /**
     * Validate edit recurrence
     *