AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Restrict task complexity to a specific range to avoid integer overflow

Browse Source
This commit is contained in:
Frederic Guillot
2016-10-08 09:58:11 -04:00
parent 1466afb771
commit c2f1cc8f74
37 changed files with 179 additions and 132 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
tests/units/Validator/CommentValidatorTest.php
View File

@@ -8,50 +8,50 @@ class CommentValidatorTest extends Base
{
public function testValidateCreation()
{
$validator = new CommentValidator($this->container);
$commentValidator = new CommentValidator($this->container);
$result = $validator->validateCreation(array('user_id' => 1, 'task_id' => 1, 'comment' => 'bla'));
$result = $commentValidator->validateCreation(array('user_id' => 1, 'task_id' => 1, 'comment' => 'bla'));
$this->assertTrue($result[0]);
$result = $validator->validateCreation(array('user_id' => 1, 'task_id' => 1, 'comment' => ''));
$result = $commentValidator->validateCreation(array('user_id' => 1, 'task_id' => 1, 'comment' => ''));
$this->assertFalse($result[0]);
$result = $validator->validateCreation(array('user_id' => 1, 'task_id' => 'a', 'comment' => 'bla'));
$result = $commentValidator->validateCreation(array('user_id' => 1, 'task_id' => 'a', 'comment' => 'bla'));
$this->assertFalse($result[0]);
$result = $validator->validateCreation(array('user_id' => 'b', 'task_id' => 1, 'comment' => 'bla'));
$result = $commentValidator->validateCreation(array('user_id' => 'b', 'task_id' => 1, 'comment' => 'bla'));
$this->assertFalse($result[0]);
$result = $validator->validateCreation(array('user_id' => 1, 'comment' => 'bla'));
$result = $commentValidator->validateCreation(array('user_id' => 1, 'comment' => 'bla'));
$this->assertFalse($result[0]);
$result = $validator->validateCreation(array('task_id' => 1, 'comment' => 'bla'));
$result = $commentValidator->validateCreation(array('task_id' => 1, 'comment' => 'bla'));
$this->assertTrue($result[0]);
$result = $validator->validateCreation(array('comment' => 'bla'));
$result = $commentValidator->validateCreation(array('comment' => 'bla'));
$this->assertFalse($result[0]);
$result = $validator->validateCreation(array());
$result = $commentValidator->validateCreation(array());
$this->assertFalse($result[0]);
}
public function testValidateModification()
{
$validator = new CommentValidator($this->container);
$commentValidator = new CommentValidator($this->container);
$result = $validator->validateModification(array('id' => 1, 'comment' => 'bla'));
$result = $commentValidator->validateModification(array('id' => 1, 'comment' => 'bla'));
$this->assertTrue($result[0]);
$result = $validator->validateModification(array('id' => 1, 'comment' => ''));
$result = $commentValidator->validateModification(array('id' => 1, 'comment' => ''));
$this->assertFalse($result[0]);
$result = $validator->validateModification(array('comment' => 'bla'));
$result = $commentValidator->validateModification(array('comment' => 'bla'));
$this->assertFalse($result[0]);
$result = $validator->validateModification(array('id' => 'b', 'comment' => 'bla'));
$result = $commentValidator->validateModification(array('id' => 'b', 'comment' => 'bla'));
$this->assertFalse($result[0]);
$result = $validator->validateModification(array());
$result = $commentValidator->validateModification(array());
$this->assertFalse($result[0]);
}
}