From c39932050ce47d7a24f4bea162060635c03a4e11 Mon Sep 17 00:00:00 2001 From: Joe Nahmias Date: Tue, 23 Aug 2022 14:48:33 -0400 Subject: [PATCH] fix(mssql): omit ORDER BY in Task WithoutTags & WithGivenTag subqueries MSSQL does not allow ORDER BY in subquery without TOP or FETCH/LIMIT --- app/Filter/TaskTagFilter.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/Filter/TaskTagFilter.php b/app/Filter/TaskTagFilter.php index e07f65cc6..793fa692a 100644 --- a/app/Filter/TaskTagFilter.php +++ b/app/Filter/TaskTagFilter.php @@ -72,7 +72,6 @@ class TaskTagFilter extends BaseFilter implements FilterInterface return $this->db ->table(TaskModel::TABLE) ->columns(TaskModel::TABLE . '.id') - ->asc(TaskModel::TABLE . '.project_id') ->left(TaskTagModel::TABLE, 'tg', 'task_id', TaskModel::TABLE, 'id') ->isNull('tg.tag_id'); } @@ -83,7 +82,6 @@ class TaskTagFilter extends BaseFilter implements FilterInterface ->table(TagModel::TABLE) ->columns(TaskTagModel::TABLE.'.task_id') ->ilike(TagModel::TABLE.'.name', $this->value) - ->asc(TagModel::TABLE.'.project_id') ->join(TaskTagModel::TABLE, 'tag_id', 'id'); } }