AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Duplicate tags when moving and duplicating tasks to another project

Browse Source
This commit is contained in:
Libin Pan
2021-06-07 19:36:08 -07:00
committed by GitHub
parent 66d9245f33
commit c6ae9f3f24
5 changed files with 28 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/units/Model/TaskProjectDuplicationModelTest.php
View File

@@ -370,8 +370,9 @@ class TaskProjectDuplicationModelTest extends Base
// Check tags
$tags = $taskTagModel->getList(2);
$this->assertCount(2, $tags);
$this->assertCount(3, $tags);
$this->assertArrayHasKey(3, $tags);
$this->assertArrayHasKey(6, $tags);
$this->assertArrayHasKey(7, $tags);
}
}

3
tests/units/Model/TaskProjectMoveModelTest.php
View File

@@ -270,8 +270,9 @@ class TaskProjectMoveModelTest extends Base
// Check tags
$tags = $taskTagModel->getList(1);
$this->assertCount(2, $tags);
$this->assertCount(3, $tags);
$this->assertArrayHasKey(5, $tags);
$this->assertArrayHasKey(6, $tags);
$this->assertArrayHasKey(7, $tags);
}
}

9
tests/units/Model/TaskTagModelTest.php
View File

@@ -129,7 +129,7 @@ class TaskTagModelTest extends Base
$this->assertEquals(array(), $tags);
}
public function testGetTagIdNotAvailableInDestinationProject()
public function testGetTagsNotAvailableInDestinationProject()
{
$projectModel = new ProjectModel($this->container);
$taskCreationModel = new TaskCreationModel($this->container);
@@ -147,6 +147,11 @@ class TaskTagModelTest extends Base
$this->assertEquals(5, $tagModel->create(1, 'T3'));
$this->assertTrue($taskTagModel->save(1, 1, array('T0', 'T2', 'T3')));
$this->assertEquals(array(4, 5), $taskTagModel->getTagIdsByTaskNotAvailableInProject(1, 2));
$tags = $taskTagModel->getTagsByTaskNotAvailableInProject(1, 2);
$this->assertCount(2, $tags);
$this->assertEquals('T2', $tags[0]['name']);
$this->assertEquals(1, $tags[0]['project_id']);
$this->assertEquals('T3', $tags[1]['name']);
$this->assertEquals(1, $tags[1]['project_id']);
}
}