AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve external link form when validation fail

Browse Source
This commit is contained in:
Frederic Guillot
2017-01-14 14:29:44 -05:00
parent 2cac4c811d
commit c6b9c72626
1 changed files with 16 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
app/Controller/TaskExternalLinkController.php
View File

@@ -76,12 +76,23 @@ class TaskExternalLinkController extends BaseController
$values = $this->request->getValues(); $values = $this->request->getValues();
list($valid, $errors) = $this->externalLinkValidator->validateCreation($values); list($valid, $errors) = $this->externalLinkValidator->validateCreation($values);
if ($valid && $this->taskExternalLinkModel->create($values) !== false) { if ($valid) {
$this->flash->success(t('Link added successfully.')); if ($this->taskExternalLinkModel->create($values) !== false) {
return $this->response->redirect($this->helper->url->to('TaskViewController', 'show', array('task_id' => $task['id'], 'project_id' => $task['project_id'])), true); $this->flash->success(t('Link added successfully.'));
} } else {
$this->flash->success(t('Unable to create your link.'));
}
return $this->edit($values, $errors); $this->response->redirect($this->helper->url->to('TaskViewController', 'show', array('task_id' => $task['id'], 'project_id' => $task['project_id'])), true);
} else {
$provider = $this->externalLinkManager->getProvider($values['link_type']);
$this->response->html($this->template->render('task_external_link/create', array(
'values' => $values,
'errors' => $errors,
'dependencies' => $provider->getDependencies(),
'task' => $task,
)));
}
} }
/** /**