Add new automatic action to move the task to another column when not moved

This commit is contained in:
Frederic Guillot 2016-07-23 18:59:00 -04:00
parent 9b2a32af78
commit ca45b5592b
No known key found for this signature in database
GPG Key ID: 92D77191BA7FBC99
4 changed files with 157 additions and 0 deletions

View File

@ -7,6 +7,7 @@ New features:
- Close tasks without activity in a specific column - Close tasks without activity in a specific column
- Set due date automatically - Set due date automatically
- Move a task to another column when closed - Move a task to another column when closed
- Move a task to another column when not moved during a given period
* Added internal task links to activity stream * Added internal task links to activity stream
* Added new event for removed comments * Added new event for removed comments
* Added search filter for task priority * Added search filter for task priority

View File

@ -0,0 +1,104 @@
<?php
namespace Kanboard\Action;
use Kanboard\Model\TaskModel;
/**
* Move a task to another column when not moved during a given period
*
* @package Kanboard\Action
* @author Frederic Guillot
*/
class TaskMoveColumnNotMovedPeriod extends Base
{
/**
* Get automatic action description
*
* @access public
* @return string
*/
public function getDescription()
{
return t('Move the task to another column when not moved during a given period');
}
/**
* Get the list of compatible events
*
* @access public
* @return array
*/
public function getCompatibleEvents()
{
return array(TaskModel::EVENT_DAILY_CRONJOB);
}
/**
* Get the required parameter for the action (defined by the user)
*
* @access public
* @return array
*/
public function getActionRequiredParameters()
{
return array(
'duration' => t('Duration in days'),
'src_column_id' => t('Source column'),
'dest_column_id' => t('Destination column'),
);
}
/**
* Get the required parameter for the event
*
* @access public
* @return string[]
*/
public function getEventRequiredParameters()
{
return array('tasks');
}
/**
* Execute the action (close the task)
*
* @access public
* @param array $data Event data dictionary
* @return bool True if the action was executed or false when not executed
*/
public function doAction(array $data)
{
$results = array();
$max = $this->getParam('duration') * 86400;
foreach ($data['tasks'] as $task) {
$duration = time() - $task['date_moved'];
if ($duration > $max && $task['column_id'] == $this->getParam('src_column_id')) {
$results[] = $this->taskPositionModel->movePosition(
$task['project_id'],
$task['id'],
$this->getParam('dest_column_id'),
1,
$task['swimlane_id'],
false
);
}
}
return in_array(true, $results, true);
}
/**
* Check if the event data meet the action condition
*
* @access public
* @param array $data Event data dictionary
* @return bool
*/
public function hasRequiredCondition(array $data)
{
return count($data['tasks']) > 0;
}
}

View File

@ -5,6 +5,7 @@ namespace Kanboard\ServiceProvider;
use Kanboard\Action\TaskAssignColorPriority; use Kanboard\Action\TaskAssignColorPriority;
use Kanboard\Action\TaskAssignDueDateOnCreation; use Kanboard\Action\TaskAssignDueDateOnCreation;
use Kanboard\Action\TaskMoveColumnClosed; use Kanboard\Action\TaskMoveColumnClosed;
use Kanboard\Action\TaskMoveColumnNotMovedPeriod;
use Pimple\Container; use Pimple\Container;
use Pimple\ServiceProviderInterface; use Pimple\ServiceProviderInterface;
use Kanboard\Core\Action\ActionManager; use Kanboard\Core\Action\ActionManager;
@ -80,6 +81,7 @@ class ActionProvider implements ServiceProviderInterface
$container['actionManager']->register(new TaskMoveColumnAssigned($container)); $container['actionManager']->register(new TaskMoveColumnAssigned($container));
$container['actionManager']->register(new TaskMoveColumnCategoryChange($container)); $container['actionManager']->register(new TaskMoveColumnCategoryChange($container));
$container['actionManager']->register(new TaskMoveColumnClosed($container)); $container['actionManager']->register(new TaskMoveColumnClosed($container));
$container['actionManager']->register(new TaskMoveColumnNotMovedPeriod($container));
$container['actionManager']->register(new TaskMoveColumnUnAssigned($container)); $container['actionManager']->register(new TaskMoveColumnUnAssigned($container));
$container['actionManager']->register(new TaskOpen($container)); $container['actionManager']->register(new TaskOpen($container));
$container['actionManager']->register(new TaskUpdateStartDate($container)); $container['actionManager']->register(new TaskUpdateStartDate($container));

View File

@ -0,0 +1,50 @@
<?php
use Kanboard\Action\TaskMoveColumnNotMovedPeriod;
use Kanboard\Event\TaskListEvent;
use Kanboard\Model\ProjectModel;
use Kanboard\Model\TaskCreationModel;
use Kanboard\Model\TaskFinderModel;
use Kanboard\Model\TaskModel;
require_once __DIR__.'/../Base.php';
class TaskMoveColumnNotMovedPeriodTest extends Base
{
public function testAction()
{
$projectModel = new ProjectModel($this->container);
$taskCreationModel = new TaskCreationModel($this->container);
$taskFinderModel = new TaskFinderModel($this->container);
$this->assertEquals(1, $projectModel->create(array('name' => 'test1')));
$this->assertEquals(1, $taskCreationModel->create(array('project_id' => 1, 'title' => 'test')));
$this->assertEquals(2, $taskCreationModel->create(array('project_id' => 1, 'title' => 'test', 'column_id' => 3)));
$this->assertEquals(3, $taskCreationModel->create(array('project_id' => 1, 'title' => 'test', 'column_id' => 2)));
$this->container['db']->table(TaskModel::TABLE)->in('id', array(2, 3))->update(array('date_moved' => strtotime('-10days')));
$tasks = $taskFinderModel->getAll(1);
$event = new TaskListEvent(array('tasks' => $tasks, 'project_id' => 1));
$action = new TaskMoveColumnNotMovedPeriod($this->container);
$action->setProjectId(1);
$action->setParam('duration', 2);
$action->setParam('src_column_id', 2);
$action->setParam('dest_column_id', 3);
$this->assertTrue($action->execute($event, TaskModel::EVENT_DAILY_CRONJOB));
$task = $taskFinderModel->getById(1);
$this->assertNotEmpty($task);
$this->assertEquals(1, $task['column_id']);
$task = $taskFinderModel->getById(2);
$this->assertNotEmpty($task);
$this->assertEquals(3, $task['column_id']);
$task = $taskFinderModel->getById(3);
$this->assertNotEmpty($task);
$this->assertEquals(3, $task['column_id']);
}
}