AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rewrite external task view component in vanilla javascript

Browse Source
This commit is contained in:
Frederic Guillot
2016-11-21 23:01:17 -05:00
parent 8976f4d15c
commit d3cb436eb5
3 changed files with 9 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Template/task/details.php
View File

@@ -161,7 +161,9 @@
</div> </div>
<?php if (! empty($task['external_uri']) && ! empty($task['external_provider'])): ?> <?php if (! empty($task['external_uri']) && ! empty($task['external_provider'])): ?>
<external-task-view url="<?= $this->url->href('ExternalTaskViewController', 'show', array('project_id' => $task['project_id'], 'task_id' => $task['id'])) ?>"></external-task-view> <?= $this->app->component('external-task-view', array(
'url' => $this->url->href('ExternalTaskViewController', 'show', array('project_id' => $task['project_id'], 'task_id' => $task['id'])),
)) ?>
<?php endif ?> <?php endif ?>
<?php if ($editable && empty($task['date_started'])): ?> <?php if ($editable && empty($task['date_started'])): ?>

2
assets/js/app.min.js vendored
View File

File diff suppressed because one or more lines are too long

17
assets/js/components/external-task-view.js
View File

@@ -1,18 +1,11 @@
Vue.component('external-task-view', { KB.component('external-task-view', function (containerElement, options) {
props: ['url'],
template: '<div id="external-task-view" v-show="content">{{{ content }}}</div>', this.render = function () {
data: function () {
return {
content: ''
};
},
ready: function () {
var self = this;
$.ajax({ $.ajax({
cache: false, cache: false,
url: this.url, url: options.url,
success: function(data) { success: function(data) {
self.content = data; KB.el(containerElement).html('<div id="external-task-view">' + data + '</div>');
} }
}); });
} }