Minor cleanup

.scrutinizer.yml

@@ -1,11 +0,0 @@
-filter:
-    paths:
-        - app/*
-    excluded_paths:
-        - app/Schema/*
-        - app/Template/*
-        - app/Locale/*
-        - app/Library/*
-        - app/constants.php
-        - app/common.php
-        - app/check_setup.php

app/Core/Base.php

@@ -185,10 +185,10 @@ abstract class Base
     }
 
     /**
-     * Load automatically models
+     * Load automatically dependencies
      *
      * @access public
-     * @param  string $name Model name
+     * @param  string $name Class name
      * @return mixed
      */
     public function __get($name)
@@ -206,7 +206,6 @@ abstract class Base
      */
     public static function getInstance(Container $container)
     {
-        $self = new static($container);
+        return new static($container);
-        return $self;
     }
 }

app/EventBuilder/EventIteratorBuilder.php

@@ -15,6 +15,10 @@ class EventIteratorBuilder implements Iterator {
     private $builders = array();
 
     /**
+     * Set builder
+     *
+     * @access public
+     * @param  BaseEventBuilder $builder
      * @return $this
      */
     public function withBuilder(BaseEventBuilder $builder)

config.default.php

@@ -11,16 +11,16 @@ define('DEBUG', false);
 define('LOG_DRIVER', '');
 
 // Log filename if the log driver is "file"
-define('LOG_FILE', __DIR__.DIRECTORY_SEPARATOR.'data'.DIRECTORY_SEPARATOR.'debug.log');
+define('LOG_FILE', DATA_DIR.DIRECTORY_SEPARATOR.'debug.log');
 
 // Plugins directory
-define('PLUGINS_DIR', 'plugins');
+define('PLUGINS_DIR', ROOT_DIR.DIRECTORY_SEPARATOR.'plugins');
 
 // Folder for uploaded files
-define('FILES_DIR', 'data'.DIRECTORY_SEPARATOR.'files');
+define('FILES_DIR', DATA_DIR.DIRECTORY_SEPARATOR.'files');
 
 // E-mail address for the "From" header (notifications)
-define('MAIL_FROM', 'notifications@kanboard.local');
+define('MAIL_FROM', 'replace-me@kanboard.local');
 
 // Mail transport available: "smtp", "sendmail", "mail" (PHP mail function), "postmark", "mailgun", "sendgrid"
 define('MAIL_TRANSPORT', 'mail');