From dcdbd3758b51a5a4e53baec6e58801c33d80d5cb Mon Sep 17 00:00:00 2001 From: Lorinczy Zsigmond Date: Fri, 15 Nov 2019 15:39:32 +0100 Subject: [PATCH] In PHP-7.4, nested ternary operators are to be bracketed (as their default association is counter-intuitive) https://wiki.php.net/rfc/ternary_associativity --- app/Model/ActionParameterModel.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Model/ActionParameterModel.php b/app/Model/ActionParameterModel.php index 66c7adb46..8df76a563 100644 --- a/app/Model/ActionParameterModel.php +++ b/app/Model/ActionParameterModel.php @@ -156,7 +156,7 @@ class ActionParameterModel extends Base case 'dst_column_id': case 'column_id': $column = $this->columnModel->getById($value); - return empty($column) ? false : $this->columnModel->getColumnIdByTitle($project_id, $column['title']) ?: false; + return empty($column) ? false : ($this->columnModel->getColumnIdByTitle($project_id, $column['title']) ?: false); case 'user_id': case 'owner_id': if ($value == 0) { @@ -165,7 +165,7 @@ class ActionParameterModel extends Base return $this->projectPermissionModel->isAssignable($project_id, $value) ? $value : false; case 'swimlane_id': $column = $this->swimlaneModel->getById($value); - return empty($column) ? false : $this->swimlaneModel->getIdByName($project_id, $column['name']) ?: false; + return empty($column) ? false : ($this->swimlaneModel->getIdByName($project_id, $column['name']) ?: false); default: return $value; }