AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use consistent swimlane and column headers

Browse Source 
Column headers now always appear above the swimlane header to allow the collapsing to work correctly.

Having the swimlane headers above column headers should be better but the current HTML/CSS implementation is limited.
This commit is contained in:
Manfred Hoffmann
2021-04-22 05:29:58 +02:00
committed by GitHub
parent ae39544e10
commit e41254ed74
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
app/Template/board/table_container.php
View File

@@ -21,8 +21,14 @@
<?php foreach ($swimlanes as $index => $swimlane): ?> <?php foreach ($swimlanes as $index => $swimlane): ?>
<?php if (! ($swimlane['nb_tasks'] === 0 && isset($not_editable))): ?> <?php if (! ($swimlane['nb_tasks'] === 0 && isset($not_editable))): ?>
<!-- Note: Do not show swimlane row on the top otherwise we can't collapse columns --> <!-- Note: Columns must render first otherwise we can't collapse them -->
<?php if ($index > 0 && $swimlane['nb_swimlanes'] > 1): ?> <?= $this->render('board/table_column', array(
'swimlane' => $swimlane,
'not_editable' => isset($not_editable),
)) ?>
<!-- Hide first swimlane-header if project has only 1 swimlane -->
<?php if ($index === 0 && $swimlane['nb_swimlanes'] > 1): ?>
<?= $this->render('board/table_swimlane', array( <?= $this->render('board/table_swimlane', array(
'project' => $project, 'project' => $project,
'swimlane' => $swimlane, 'swimlane' => $swimlane,
@@ -30,12 +36,7 @@
)) ?> )) ?>
<?php endif ?> <?php endif ?>
<?= $this->render('board/table_column', array( <?php if ($index > 0 && $swimlane['nb_swimlanes'] > 1): ?>
'swimlane' => $swimlane,
'not_editable' => isset($not_editable),
)) ?>
<?php if ($index === 0 && $swimlane['nb_swimlanes'] > 1): ?>
<?= $this->render('board/table_swimlane', array( <?= $this->render('board/table_swimlane', array(
'project' => $project, 'project' => $project,
'swimlane' => $swimlane, 'swimlane' => $swimlane,