Add jshint

.travis.yml

@@ -24,6 +24,8 @@ before_script:
   - if [[ $TRAVIS_PHP_VERSION != 7.x ]]; then phpenv config-rm xdebug.ini; fi
   - phpenv config-add tests/php.ini
   - composer install
+  - npm install
+  - ./node_modules/.bin/jshint assets/js/{core,components}
 
 script:
   - phpunit -c tests/units.$DB.xml

Makefile

@@ -9,6 +9,7 @@ static: clean
 	@ npm install
 	@ ./node_modules/.bin/gulp bower
 	@ ./node_modules/.bin/gulp vendor js css
+	@ ./node_modules/.bin/jshint assets/js/{core,components}
 
 archive:
 	@ echo "Build archive: version=${version}, destination=${dst}"

assets/js/components/chart-project-burndown.js

@@ -11,22 +11,21 @@ KB.component('chart-project-burndown', function (containerElement, options) {
 
             for (var j = 0; j < metrics[i].length; j++) {
 
-                if (i == 0) {
+                if (i === 0) {
                     columns.push([metrics[i][j]]);
-                }
+                } else {
-                else {
                     columns[j + 1].push(metrics[i][j]);
 
                     if (j > 0) {
 
-                        if (columns[0][i] == undefined) {
+                        if (columns[0][i] === undefined) {
                             columns[0].push(0);
                         }
 
                         columns[0][i] += metrics[i][j];
                     }
 
-                    if (j == 0) {
+                    if (j === 0) {
                         categories.push(outputFormat(inputFormat.parse(metrics[i][j])));
                     }
                 }

assets/js/components/chart-project-cumulative-flow.js

@@ -12,18 +12,17 @@ KB.component('chart-project-cumulative-flow', function (containerElement, option
 
             for (var j = 0; j < metrics[i].length; j++) {
 
-                if (i == 0) {
+                if (i === 0) {
                     columns.push([metrics[i][j]]);
 
                     if (j > 0) {
                         groups.push(metrics[i][j]);
                     }
-                }
+                } else {
-                else {
 
                     columns[j].push(metrics[i][j]);
 
-                    if (j == 0) {
+                    if (j === 0) {
                         categories.push(outputFormat(inputFormat.parse(metrics[i][j])));
                     }
                 }

assets/js/components/external-task-view.js

@@ -8,5 +8,5 @@ KB.component('external-task-view', function (containerElement, options) {
                 KB.dom(containerElement).html('<div id="external-task-view">' + data + '</div>');
             }
         });
-    }
+    };
 });

assets/js/core/kb.js

@@ -1,5 +1,3 @@
-'use strict';
-
 var KB = {
     components: {},
     utils: {},

assets/js/src/App.js

@@ -135,7 +135,7 @@ Kanboard.App.prototype.datePicker = function() {
 Kanboard.App.prototype.tagAutoComplete = function() {
     $(".tag-autocomplete").select2({
         tags: true
-    })
+    });
 };
 
 Kanboard.App.prototype.autoComplete = function() {
@@ -144,7 +144,7 @@ Kanboard.App.prototype.autoComplete = function() {
         var field = input.data("dst-field");
         var extraField = input.data("dst-extra-field");
 
-        if ($('#form-' + field).val() == '') {
+        if ($('#form-' + field).val() === '') {
             input.parent().find("button[type=submit]").attr('disabled','disabled');
         }
 
@@ -189,7 +189,7 @@ Kanboard.App.prototype.isVisible = function() {
         property = "webkitVisibilityState";
     }
 
-    if (property != "") {
+    if (property !== "") {
         return document[property] == "visible";
     }
 

assets/js/src/BoardDragAndDrop.js

@@ -45,7 +45,7 @@ Kanboard.BoardDragAndDrop.prototype.dragAndDrop = function() {
 
     if (isMobile.any) {
         $(".task-board-sort-handle").css("display", "inline");
-        params["handle"] = ".task-board-sort-handle";
+        params.handle = ".task-board-sort-handle";
     }
 
     // Set dropzone height to the height of the table cell

assets/js/src/Namespace.js

@@ -1,3 +1 @@
-'use strict';
-
 var Kanboard = {};

assets/js/src/Screenshot.js

@@ -44,7 +44,7 @@ Kanboard.Screenshot.prototype.initialize = function() {
 
 // Destroy contentEditable element
 Kanboard.Screenshot.prototype.destroy = function() {
-    if (this.pasteCatcher != null) {
+    if (this.pasteCatcher !== null) {
         document.body.removeChild(this.pasteCatcher);
     }
     else if (document.getElementById("screenshot-pastezone")) {

package.json

@@ -10,5 +10,8 @@
     "gulp-strip-comments": "^2.4.3",
     "gulp-uglify": "^1.5.3",
     "vue": "1.0.26-csp"
+  },
+  "devDependencies": {
+    "jshint": "^2.9.4"
   }
 }