Add aria-label to icons with title attributes

This commit is contained in:
Michael Vickers
2020-10-02 21:48:19 +01:00
committed by Frédéric Guillot
parent de56529291
commit eafd82f564
11 changed files with 37 additions and 31 deletions

View File

@@ -42,13 +42,13 @@
<div class="task-board-icons-row">
<?php if ($task['is_milestone'] == 1): ?>
<span title="<?= t('Milestone') ?>">
<i class="fa fa-flag flag-milestone"></i>
<i class="fa fa-flag flag-milestone" role="img" aria-label="<?= t('Milestone') ?>"></i>
</span>
<?php endif ?>
<?php if ($task['score']): ?>
<span class="task-score" title="<?= t('Complexity') ?>">
<i class="fa fa-trophy"></i>
<i class="fa fa-trophy" role="img" aria-label="<?= t('Complexity') ?>"></i>
<?= $this->text->e($task['score']) ?>
</span>
<?php endif ?>
@@ -104,7 +104,8 @@
<?php if ($task['nb_comments'] > 0): ?>
<?php if ($not_editable): ?>
<span title="<?= $task['nb_comments'] == 1 ? t('%d comment', $task['nb_comments']) : t('%d comments', $task['nb_comments']) ?>"><i class="fa fa-comments-o"></i>&nbsp;<?= $task['nb_comments'] ?></span>
<?php $aria_label = $task['nb_comments'] == 1 ? t('%d comment', $task['nb_comments']) : t('%d comments', $task['nb_comments']); ?>
<span title="<?= $aria_label ?>" role="img" aria-label="<?= $aria_label ?>"><i class="fa fa-comments-o"></i>&nbsp;<?= $task['nb_comments'] ?></span>
<?php else: ?>
<?= $this->modal->medium(
'comments-o',