Reduce the number of SQL queries for automatic actions

2014-12-31 14:15:42 -05:00
parent 27f4537079
commit ee8ec7685f
1 changed files with 9 additions and 1 deletions
--- a/app/Model/Action.php
+++ b/app/Model/Action.php
@@ -140,9 +140,17 @@ class Action extends Base
    public function getAll()
    {
        $actions = $this->db->table(self::TABLE)->findAll();
+        $params = $this->db->table(self::TABLE_PARAMS)->findAll();

        foreach ($actions as &$action) {
-            $action['params'] = $this->db->table(self::TABLE_PARAMS)->eq('action_id', $action['id'])->findAll();
+
+            $action['params'] = array();
+
+            foreach ($params as $param) {
+                if ($param['action_id'] === $action['id']) {
+                    $action['params'][] = $param;
+                }
+            }
        }

        return $actions;