PHP 8 Compatibility

This commit is contained in:
Frédéric Guillot
2022-02-05 11:49:03 -08:00
committed by GitHub
parent 61e63ef9e0
commit f5bb55bdb8
558 changed files with 6262 additions and 21691 deletions

View File

@@ -45,9 +45,10 @@ class CommentEventJobTest extends Base
$this->assertTrue($commentModel->remove(1));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(CommentModel::EVENT_CREATE.'.closure', $called);
$this->assertArrayHasKey(CommentModel::EVENT_UPDATE.'.closure', $called);
$this->assertArrayHasKey(CommentModel::EVENT_DELETE.'.closure', $called);
$this->assertCount(3, $called);
$this->assertEquals(CommentModel::EVENT_CREATE, $called[0]['event']);
$this->assertEquals(CommentModel::EVENT_UPDATE, $called[1]['event']);
$this->assertEquals(CommentModel::EVENT_DELETE, $called[2]['event']);
}
public function testThatUserMentionJobIsCalled()

View File

@@ -38,6 +38,7 @@ class ProjectFileEventJobTest extends Base
$this->assertEquals(1, $projectFileModel->create(1, 'Test', '/tmp/test', 123));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(ProjectFileModel::EVENT_CREATE.'.closure', $called);
$this->assertCount(1, $called);
$this->assertEquals(ProjectFileModel::EVENT_CREATE, $called[0]['event']);
}
}

View File

@@ -46,9 +46,6 @@ class SubtaskEventJobTest extends Base
$this->assertTrue($subtaskModel->remove(1));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(SubtaskModel::EVENT_CREATE.'.closure', $called);
$this->assertArrayHasKey(SubtaskModel::EVENT_UPDATE.'.closure', $called);
$this->assertArrayHasKey(SubtaskModel::EVENT_DELETE.'.closure', $called);
$this->assertArrayHasKey(SubtaskModel::EVENT_CREATE_UPDATE.'.closure', $called);
$this->assertCount(5, $called);
}
}

View File

@@ -48,8 +48,7 @@ class TaskEventJobTest extends Base
$this->assertEquals(1, $taskCreationModel->create(array('title' => 'test', 'project_id' => 1)));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_CREATE.'.closure', $called);
$this->assertArrayHasKey(TaskModel::EVENT_CREATE_UPDATE.'.closure', $called);
$this->assertCount(2, $called);
}
public function testTriggerUpdateEvent()
@@ -66,8 +65,7 @@ class TaskEventJobTest extends Base
$this->assertTrue($taskModificationModel->update(array('id' => 1, 'title' => 'new title')));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_UPDATE.'.closure', $called);
$this->assertArrayHasKey(TaskModel::EVENT_CREATE_UPDATE.'.closure', $called);
$this->assertCount(3, $called);
}
public function testTriggerAssigneeChangeEvent()
@@ -83,7 +81,7 @@ class TaskEventJobTest extends Base
$this->assertTrue($taskModificationModel->update(array('id' => 1, 'owner_id' => 1)));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_ASSIGNEE_CHANGE.'.closure', $called);
$this->assertCount(1, $called);
}
public function testTriggerCloseEvent()
@@ -99,7 +97,7 @@ class TaskEventJobTest extends Base
$this->assertTrue($taskStatusModel->close(1));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_CLOSE.'.closure', $called);
$this->assertCount(1, $called);
}
public function testTriggerOpenEvent()
@@ -116,7 +114,7 @@ class TaskEventJobTest extends Base
$this->assertTrue($taskStatusModel->open(1));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_OPEN.'.closure', $called);
$this->assertCount(1, $called);
}
public function testTriggerMovePositionEvent()
@@ -133,7 +131,7 @@ class TaskEventJobTest extends Base
$this->assertTrue($taskPositionModel->movePosition(1, 1, 1, 2));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_MOVE_POSITION.'.closure', $called);
$this->assertCount(1, $called);
}
public function testTriggerMoveColumnEvent()
@@ -149,7 +147,7 @@ class TaskEventJobTest extends Base
$this->assertTrue($taskPositionModel->movePosition(1, 1, 2, 2));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_MOVE_COLUMN.'.closure', $called);
$this->assertCount(1, $called);
}
public function testTriggerMoveSwimlaneEvent()
@@ -167,7 +165,7 @@ class TaskEventJobTest extends Base
$this->assertTrue($taskPositionModel->movePosition(1, 1, 1, 1, 2));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_MOVE_SWIMLANE.'.closure', $called);
$this->assertCount(1, $called);
}
public function testTriggerMoveProjectEvent()
@@ -184,7 +182,7 @@ class TaskEventJobTest extends Base
$this->assertTrue($taskProjectMoveModel->moveToProject(1, 1));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_MOVE_PROJECT.'.closure', $called);
$this->assertCount(1, $called);
}
public function testThatUserMentionJobIsCalled()

View File

@@ -41,6 +41,6 @@ class TaskFileEventJobTest extends Base
$this->assertEquals(1, $taskFileModel->create(1, 'Test', '/tmp/test', 123));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskFileModel::EVENT_CREATE.'.closure', $called);
$this->assertCount(1, $called);
}
}

View File

@@ -42,7 +42,7 @@ class TaskLinkEventJobTest extends Base
$this->assertEquals(1, $taskLinkModel->create(1, 2, 1));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskLinkModel::EVENT_CREATE_UPDATE.'.closure', $called);
$this->assertCount(2, $called);
}
public function testTriggerDeleteEvents()
@@ -60,6 +60,6 @@ class TaskLinkEventJobTest extends Base
$this->assertTrue($taskLinkModel->remove(1));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskLinkModel::EVENT_DELETE.'.closure', $called);
$this->assertCount(1, $called);
}
}

View File

@@ -99,7 +99,7 @@ class UserMentionJobTest extends Base
$userMentionJob->execute('test @user1 @user2', TaskModel::EVENT_USER_MENTION, $event->getAll());
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_USER_MENTION.'.UserMentionJobTest::onUserMention', $called);
$this->assertCount(1, $called);
}
public function onUserMention($event)