AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PHP 8 Compatibility

Browse Source
This commit is contained in:
Frédéric Guillot
2022-02-05 11:49:03 -08:00
committed by GitHub
parent 61e63ef9e0
commit f5bb55bdb8
558 changed files with 6262 additions and 21691 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/units/Model/ProjectDailyStatsTest.php
View File

@@ -45,10 +45,10 @@ class ProjectDailyStatsTest extends Base
$this->assertEquals($expected[0]['day'], $metrics[0]['day']);
$this->assertEquals($expected[1]['day'], $metrics[1]['day']);
$this->assertEquals($expected[0]['avg_lead_time'], $metrics[0]['avg_lead_time'], '', 2);
$this->assertEquals($expected[1]['avg_lead_time'], $metrics[1]['avg_lead_time'], '', 2);
$this->assertEquals($expected[0]['avg_lead_time'], $metrics[0]['avg_lead_time'], '', 5);
$this->assertEquals($expected[1]['avg_lead_time'], $metrics[1]['avg_lead_time'], '', 5);
$this->assertEquals($expected[0]['avg_cycle_time'], $metrics[0]['avg_cycle_time'], '', 2);
$this->assertEquals($expected[1]['avg_cycle_time'], $metrics[1]['avg_cycle_time'], '', 2);
$this->assertEquals($expected[0]['avg_cycle_time'], $metrics[0]['avg_cycle_time'], '', 5);
$this->assertEquals($expected[1]['avg_cycle_time'], $metrics[1]['avg_cycle_time'], '', 5);
}
}

3
tests/units/Model/ProjectModelTest.php
View File

@@ -281,7 +281,8 @@ class ProjectModelTest extends Base
$this->assertEquals(1, $taskCreationModel->create(array('title' => 'Task #1', 'project_id' => 1)));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_CREATE_UPDATE.'.Kanboard\Subscriber\ProjectModificationDateSubscriber::execute', $called);
$this->assertCount(1, $called);
$this->assertEquals(TaskModel::EVENT_CREATE_UPDATE, $called[0]['event']);
$project = $projectModel->getById(1);
$this->assertNotEmpty($project);

6
tests/units/Model/TaskCreationModelTest.php
View File

@@ -33,8 +33,7 @@ class TaskCreationModelTest extends Base
$this->assertEquals(1, $taskCreationModel->create(array('project_id' => 1)));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_CREATE_UPDATE.'.closure', $called);
$this->assertArrayHasKey(TaskModel::EVENT_CREATE.'.closure', $called);
$this->assertCount(2, $called);
$task = $taskFinderModel->getById(1);
$this->assertNotEmpty($task);
@@ -56,8 +55,7 @@ class TaskCreationModelTest extends Base
$this->assertEquals(1, $taskCreationModel->create(array('project_id' => 1, 'title' => 'test')));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_CREATE_UPDATE.'.closure', $called);
$this->assertArrayHasKey(TaskModel::EVENT_CREATE.'.TaskCreationModelTest::onCreate', $called);
$this->assertCount(2, $called);
$task = $finderModel->getById(1);
$this->assertNotEmpty($task);

3
tests/units/Model/TaskDuplicationModelTest.php
View File

@@ -80,8 +80,7 @@ class TaskDuplicationModelTest extends Base
$this->assertEquals(2, $taskDuplicationModel->duplicate(1));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_CREATE_UPDATE.'.closure', $called);
$this->assertArrayHasKey(TaskModel::EVENT_CREATE.'.closure', $called);
$this->assertCount(2, $called);
// Check the values of the duplicated task
$task = $taskFinderModel->getById(2);

5
tests/units/Model/TaskModificationModelTest.php
View File

@@ -75,8 +75,7 @@ class TaskModificationModelTest extends Base
$this->assertTrue($taskModificationModel->update(array('id' => 1, 'title' => 'After')));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_CREATE_UPDATE.'.TaskModificationModelTest::onCreateUpdate', $called);
$this->assertArrayHasKey(TaskModel::EVENT_UPDATE.'.TaskModificationModelTest::onUpdate', $called);
$this->assertCount(2, $called);
$task = $taskFinderModel->getById(1);
$this->assertEquals('After', $task['title']);
@@ -100,7 +99,7 @@ class TaskModificationModelTest extends Base
$this->assertTrue($taskModificationModel->update(array('id' => 1, 'owner_id' => 1)));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_ASSIGNEE_CHANGE.'.TaskModificationModelTest::onAssigneeChange', $called);
$this->assertCount(1, $called);
$task = $taskFinderModel->getById(1);
$this->assertEquals(1, $task['owner_id']);

9
tests/units/Model/TaskPositionModelTest.php
View File

@@ -552,8 +552,7 @@ class TaskPositionModelTest extends Base
$this->assertEquals(2, $task['position']);
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_MOVE_COLUMN.'.TaskPositionModelTest::onMoveColumn', $called);
$this->assertEquals(1, count($called));
$this->assertCount(1, $called);
// We move the task 1 to the position 2
$this->assertTrue($taskPositionModel->movePosition(1, 1, 2, 2));
@@ -569,8 +568,7 @@ class TaskPositionModelTest extends Base
$this->assertEquals(1, $task['position']);
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_MOVE_POSITION.'.TaskPositionModelTest::onMovePosition', $called);
$this->assertEquals(2, count($called));
$this->assertCount(2, $called);
// Move to another swimlane
$this->assertTrue($taskPositionModel->movePosition(1, 1, 3, 1, 2));
@@ -588,8 +586,7 @@ class TaskPositionModelTest extends Base
$this->assertEquals(1, $task['swimlane_id']);
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_MOVE_SWIMLANE.'.TaskPositionModelTest::onMoveSwimlane', $called);
$this->assertEquals(3, count($called));
$this->assertCount(3, $called);
}
public function onMoveColumn($event)

3
tests/units/Model/TaskProjectDuplicationModelTest.php
View File

@@ -47,8 +47,7 @@ class TaskProjectDuplicationModelTest extends Base
$this->assertEquals(2, $taskProjectDuplicationModel->duplicateToProject(1, 2));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_CREATE_UPDATE.'.closure', $called);
$this->assertArrayHasKey(TaskModel::EVENT_CREATE.'.closure', $called);
$this->assertCount(2, $called);
// Check the values of the duplicated task
$task = $taskFinderModel->getById(2);

2
tests/units/Model/TaskProjectMoveModelTest.php
View File

@@ -54,7 +54,7 @@ class TaskProjectMoveModelTest extends Base
$this->assertTrue($taskProjectMoveModel->moveToProject(1, 2));
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey(TaskModel::EVENT_MOVE_PROJECT.'.TaskProjectMoveModelTest::onMoveProject', $called);
$this->assertCount(1, $called);
// Check the values of the moved task
$task = $taskFinderModel->getById(1);

3
tests/units/Model/TaskStatusModelTest.php
View File

@@ -100,8 +100,7 @@ class TaskStatusModelTest extends Base
$this->assertEquals(time(), $task['date_modification'], '', 1);
$called = $this->container['dispatcher']->getCalledListeners();
$this->assertArrayHasKey('task.close.TaskStatusModelTest::onTaskClose', $called);
$this->assertArrayHasKey('task.open.TaskStatusModelTest::onTaskOpen', $called);
$this->assertCount(2, $called);
}
public function onTaskOpen($event)