AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Sqlite migrations should have foreign keys disabled outside the transaction

Browse Source 
Existing behavior could lead to data loss if schema is changed.
This commit is contained in:
Frédéric Guillot
2020-12-28 11:30:39 -08:00
committed by fguillot
parent aad436d219
commit fdbbb29cd6
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libs/picodb/lib/PicoDb/Schema.php
View File

@@ -93,8 +93,8 @@ class Schema
{ {
try { try {
for ($i = $current_version + 1; $i <= $next_version; $i++) { for ($i = $current_version + 1; $i <= $next_version; $i++) {
$this->db->startTransaction();
$this->db->getDriver()->disableForeignKeys(); $this->db->getDriver()->disableForeignKeys();
$this->db->startTransaction();
$function_name = $this->getNamespace().'\version_'.$i; $function_name = $this->getNamespace().'\version_'.$i;
@@ -104,8 +104,8 @@ class Schema
} }
$this->db->getDriver()->setSchemaVersion($i); $this->db->getDriver()->setSchemaVersion($i);
$this->db->getDriver()->enableForeignKeys();
$this->db->closeTransaction(); $this->db->closeTransaction();
$this->db->getDriver()->enableForeignKeys();
} }
} catch (PDOException $e) { } catch (PDOException $e) {
$this->db->setLogMessage($e->getMessage()); $this->db->setLogMessage($e->getMessage());