Commit Graph

11 Commits

Author SHA1 Message Date
Miodrag Tokić eccfff451a Limit assignee drop-down selector scope
On the task details page "Add a sub-task" pop-up modal contains
drop-down (the SELECT HTML element) with "form-user_id" as the `name`
and the `id` attribute value. This element is in conflict with another,
hidden INPUT element with the same `name` and the `id` value. This
causes an issue where clicking the "Me" (Assignee) link / shortcut (A)
element doesn't select your name in the Assignee SELECT element.

Avoiding conflict by changing the SELECT element `id` value is not
possible as the SELECT element is generated using `FormHelper::select()`
function which uses the same value for attribute `name` and `id`.

Given the assignee shortcut feature is used only in two places: edit
task and edit sub-task dialog, the simplest solution is to select the
closest SELECT element to the link / shortcut (A) element or limit the
scope to the currently opened dialog.

This fix uses the latter approach by limiting the scope of targeted
selector.
2018-12-20 13:57:43 +01:00
Frederic Guillot 3833c12ccc Refactoring/rewrite of modal boxes handling 2017-01-02 17:01:27 -05:00
Frederic Guillot ff79ec72c1 Remove dependency on Mousetrap 2016-12-30 20:14:36 -05:00
Frederic Guillot cead21691e
Removed useless keyboard shortcut 2016-06-24 19:31:34 -04:00
Frederic Guillot 17213da5ce
Use the same task form layout everywhere 2016-06-24 17:57:26 -04:00
Frederic Guillot 4c733eb715 Addded new keyboard shortcut to edit the task description 2016-03-20 16:29:20 -04:00
Frederic Guillot f77d6c590b Added Markdown editor and Javascript code refactoring 2016-03-20 15:45:02 -04:00
Frederic Guillot 4f54a547fa Added new keyboard shortcut for task view 2016-03-11 22:46:54 -05:00
Frederic Guillot a6540bc604 Fix regression: unable to change project in "task move/duplicate to another project" 2016-02-23 21:57:54 -05:00
Frederic Guillot 9570793f68 Add a "Me" button to assignee form element 2016-01-31 11:05:47 -05:00
Frederic Guillot c62e14f1cc Replace color dropdown by color picker in task forms 2015-09-05 18:24:46 -04:00