replace all instances of mysqli_fetch_array with mysqli_fetch_assoc for better performance and memory usage

This commit is contained in:
johnnyq
2026-01-14 17:30:23 -05:00
parent cb8b99d6ae
commit 0a30300bde
361 changed files with 1880 additions and 1904 deletions

View File

@@ -14,7 +14,7 @@ if ($session_contact_primary == 0 && !$session_contact_is_billing_contact) {
exit();
}
$recurring_invoices_sql = mysqli_query($mysqli, "SELECT * FROM recurring_invoices
$recurring_invoices_sql = mysqli_query($mysqli, "SELECT * FROM recurring_invoices
LEFT JOIN recurring_payments ON recurring_payment_recurring_invoice_id = recurring_invoice_id
WHERE recurring_invoice_client_id = $session_client_id
AND recurring_invoice_status = 1
@@ -23,7 +23,7 @@ $recurring_invoices_sql = mysqli_query($mysqli, "SELECT * FROM recurring_invoice
// Get Payment Provide Details
$payment_provider_sql = mysqli_query($mysqli, "SELECT * FROM payment_providers WHERE payment_provider_active = 1 LIMIT 1");
$row = mysqli_fetch_array($payment_provider_sql);
$row = mysqli_fetch_assoc($payment_provider_sql);
$payment_provider_id = intval($row['payment_provider_id']);
$payment_provider_name = nullable_htmlentities($row['payment_provider_name']);
$payment_provider_threshold = floatval($row['payment_provider_threshold']);
@@ -50,7 +50,7 @@ $payment_provider_threshold = floatval($row['payment_provider_threshold']);
<tbody>
<?php
while ($row = mysqli_fetch_array($recurring_invoices_sql)) {
while ($row = mysqli_fetch_assoc($recurring_invoices_sql)) {
$recurring_invoice_id = intval($row['recurring_invoice_id']);
$recurring_invoice_prefix = nullable_htmlentities($row['recurring_invoice_prefix']);
$recurring_invoice_number = intval($row['recurring_invoice_number']);
@@ -62,7 +62,7 @@ $payment_provider_threshold = floatval($row['payment_provider_threshold']);
$recurring_payment_id = intval($row['recurring_payment_id']);
$recurring_payment_recurring_invoice_id = intval($row['recurring_payment_recurring_invoice_id']);
$recurring_payment_saved_payment_id = intval($row['recurring_payment_saved_payment_id']);
if (empty($recurring_invoice_scope)) {
$recurring_invoice_scope_display = "-";
} else {
@@ -85,7 +85,7 @@ $payment_provider_threshold = floatval($row['payment_provider_threshold']);
<select class="form-control select2" name="saved_payment_id" onchange="this.form.submit()">
<option value="0">Disabled</option>
<?php
while ($row = mysqli_fetch_array($sql)) {
while ($row = mysqli_fetch_assoc($sql)) {
$saved_payment_id = intval($row['saved_payment_id']);
$saved_payment_description = nullable_htmlentities($row['saved_payment_description']);