diff --git a/agent/asset.php b/agent/asset.php index a23ff0f44..f5b5bed51 100644 --- a/agent/asset.php +++ b/agent/asset.php @@ -1156,16 +1156,7 @@ if (isset($_GET['asset_id'])) { } else { $ticket_priority_display = "-"; } - $ticket_assigned_to = intval($row['ticket_assigned_to']); - if (empty($ticket_assigned_to)) { - if ($ticket_status_id == 5) { - $ticket_assigned_to_display = "
Not Assigned
"; - } else { - $ticket_assigned_to_display = "Not Assigned
"; - } - } else { - $ticket_assigned_to_display = escapeHtml($row['user_name']); - } + $ticket_assigned_to_display = formatAssignee($row['ticket_assigned_to'], $row['user_name'], $row['user_avatar'], !in_array($ticket_status_id, [4, 5])); ?> diff --git a/agent/contact.php b/agent/contact.php index 764751df6..7366b5b3a 100644 --- a/agent/contact.php +++ b/agent/contact.php @@ -118,7 +118,7 @@ if (isset($_GET['contact_id'])) { // Related Tickets Query - 1 to 1 relationship $sql_related_tickets = mysqli_query($mysqli, "SELECT ticket_assigned_to, ticket_closed_at, ticket_created_at, ticket_id, ticket_number, ticket_prefix, ticket_priority, ticket_status, ticket_status_color, ticket_status_name, - ticket_subject, ticket_updated_at, user_name FROM tickets + ticket_subject, ticket_updated_at, user_avatar, user_name FROM tickets LEFT JOIN users ON ticket_assigned_to = user_id LEFT JOIN ticket_statuses ON ticket_status = ticket_status_id WHERE ticket_contact_id = $contact_id ORDER BY ticket_id DESC"); @@ -885,16 +885,7 @@ if (isset($_GET['contact_id'])) { } else { $ticket_priority_display = "-"; } - $ticket_assigned_to = intval($row['ticket_assigned_to']); - if (empty($ticket_assigned_to)) { - if ($ticket_status == "Closed") { - $ticket_assigned_to_display = "Not Assigned
"; - } else { - $ticket_assigned_to_display = "Not Assigned
"; - } - } else { - $ticket_assigned_to_display = escapeHtml($row['user_name']); - } + $ticket_assigned_to_display = formatAssignee($row['ticket_assigned_to'], $row['user_name'], $row['user_avatar'], !in_array(intval($row['ticket_status']), [4, 5])); ?> diff --git a/agent/modals/asset/asset.php b/agent/modals/asset/asset.php index 1fa8813e1..508bf800b 100644 --- a/agent/modals/asset/asset.php +++ b/agent/modals/asset/asset.php @@ -687,16 +687,7 @@ ob_start(); } else { $ticket_priority_display = "-"; } - $ticket_assigned_to = intval($row['ticket_assigned_to']); - if (empty($ticket_assigned_to)) { - if ($ticket_status_id == 5) { - $ticket_assigned_to_display = "Not Assigned
"; - } else { - $ticket_assigned_to_display = "Not Assigned
"; - } - } else { - $ticket_assigned_to_display = escapeHtml($row['user_name']); - } + $ticket_assigned_to_display = formatAssignee($row['ticket_assigned_to'], $row['user_name'], $row['user_avatar'], !in_array($ticket_status_id, [4, 5])); ?> diff --git a/agent/modals/contact/contact.php b/agent/modals/contact/contact.php index d07635c9b..862c7b979 100644 --- a/agent/modals/contact/contact.php +++ b/agent/modals/contact/contact.php @@ -99,7 +99,7 @@ $credential_count = mysqli_num_rows($sql_related_credentials); // Related Tickets Query - 1 to 1 relationship $sql_related_tickets = mysqli_query($mysqli, "SELECT ticket_assigned_to, ticket_created_at, ticket_id, ticket_number, ticket_prefix, ticket_priority, ticket_status, ticket_status_color, ticket_status_name, ticket_subject, - ticket_updated_at, user_name FROM tickets + ticket_updated_at, user_avatar, user_name FROM tickets LEFT JOIN users ON ticket_assigned_to = user_id LEFT JOIN ticket_statuses ON ticket_status = ticket_status_id WHERE ticket_contact_id = $contact_id @@ -658,16 +658,7 @@ ob_start(); $ticket_priority_display = "-"; } - $ticket_assigned_to = intval($row['ticket_assigned_to']); - if (empty($ticket_assigned_to)) { - if ($ticket_status == "Closed") { - $ticket_assigned_to_display = "Not Assigned
"; - } else { - $ticket_assigned_to_display = "Not Assigned
"; - } - } else { - $ticket_assigned_to_display = escapeHtml($row['user_name']); - } + $ticket_assigned_to_display = formatAssignee($row['ticket_assigned_to'], $row['user_name'], $row['user_avatar'], !in_array(intval($row['ticket_status']), [4, 5])); ?>Not Assigned
"; - } else { - $ticket_assigned_to_display = "Not Assigned
"; - } - } else { - $ticket_assigned_to_display = escapeHtml($row['user_name']); - } + $ticket_assigned_to_display = formatAssignee($row['ticket_assigned_to'], $row['user_name'], $row['user_avatar'], !in_array($ticket_status, [4, 5])); $project_id = intval($row['ticket_project_id']); diff --git a/agent/recurring_tickets.php b/agent/recurring_tickets.php index 387bc8f29..9a3db471e 100644 --- a/agent/recurring_tickets.php +++ b/agent/recurring_tickets.php @@ -295,7 +295,7 @@ $num_rows = mysqli_fetch_row(mysqli_query($mysqli, "SELECT FOUND_ROWS()")); } $recurring_ticket_category = escapeHtml($row['category_name']) ?: '-'; $recurring_ticket_client_name = escapeHtml($row['client_name']); - $assigned_to = escapeHtml($row['user_name']) ?: '-'; + $assigned_to = formatAssignee($row['recurring_ticket_assigned_to'], $row['user_name'], $row['user_avatar'], false); $recurring_ticket_template_name = escapeHtml($row['ticket_template_name']); $recurring_ticket_task_count = intval($row['recurring_ticket_task_count']); ?> diff --git a/agent/ticket.php b/agent/ticket.php index 3ff5da964..3a8eb0db4 100644 --- a/agent/ticket.php +++ b/agent/ticket.php @@ -130,12 +130,7 @@ if (isset($_GET['ticket_id'])) { $ticket_is_open = !$ticket_is_resolved && !$ticket_is_closed; $can_edit_ticket = lookupUserPermission("module_support") >= 2; - $ticket_assigned_to = intval($ticket['ticket_assigned_to']); - if (empty($ticket_assigned_to)) { - $ticket_assigned_to_display = "Unassigned"; - } else { - $ticket_assigned_to_display = escapeHtml($ticket['user_name']); - } + $ticket_assigned_to_display = formatAssignee($ticket['ticket_assigned_to'], $ticket['user_name'], $ticket['user_avatar'], $ticket_is_open); // Tab Title // No Sanitizing needed $page_title = $ticket['ticket_subject']; @@ -604,7 +599,7 @@ if (isset($_GET['ticket_id'])) {