AS1024/itflow
1
0
Fork 0
mirror of https://github.com/itflow-org/itflow synced 2026-08-19 14:05:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

API: Invoice_items only return if item_id or invoice_id is specified and do not return all invoice items

Browse Source
This commit is contained in:
johnnyq
2026-04-11 17:57:22 -04:00
parent 81f87e3960
commit 1e02322382
1 changed files with 12 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
api/v1/invoice_items/read.php
View File

@@ -1,5 +1,4 @@
<?php <?php
/* /*
* API - Invoice Items - Read * API - Invoice Items - Read
* GET /api/v1/invoice_items/read.php * GET /api/v1/invoice_items/read.php
@@ -8,8 +7,9 @@
* *
* Parameters (GET): * Parameters (GET):
* api_key required - Your API key * api_key required - Your API key
* invoice_id optional - Return items for a single invoice * invoice_id required* - Return items for a single invoice
* item_id optional - Return a single line item by its own ID * item_id required* - Return a single line item by its own ID
* * One of invoice_id or item_id must be provided
* limit optional - Max rows to return (default 50) * limit optional - Max rows to return (default 50)
* offset optional - Offset for pagination (default 0) * offset optional - Offset for pagination (default 0)
* *
@@ -22,16 +22,12 @@
* which causes the LIKE to match every client — consistent with other * which causes the LIKE to match every client — consistent with other
* endpoints in this API. * endpoints in this API.
*/ */
require_once '../validate_api_key.php'; require_once '../validate_api_key.php';
require_once '../require_get_method.php'; require_once '../require_get_method.php';
if (isset($_GET['item_id'])) { if (isset($_GET['item_id'])) {
// Single line item by item_id — still JOIN to invoices to enforce client scope // Single line item by item_id — still JOIN to invoices to enforce client scope
$item_id = intval($_GET['item_id']); $item_id = intval($_GET['item_id']);
$sql = mysqli_query($mysqli, $sql = mysqli_query($mysqli,
"SELECT ii.* "SELECT ii.*
FROM invoice_items ii FROM invoice_items ii
@@ -40,11 +36,9 @@ if (isset($_GET['item_id'])) {
AND i.invoice_client_id LIKE '$client_id' AND i.invoice_client_id LIKE '$client_id'
LIMIT 1" LIMIT 1"
); );
} elseif (isset($_GET['invoice_id'])) { } elseif (isset($_GET['invoice_id'])) {
// All items on a specific invoice // All items on a specific invoice
$invoice_id = intval($_GET['invoice_id']); $invoice_id = intval($_GET['invoice_id']);
$sql = mysqli_query($mysqli, $sql = mysqli_query($mysqli,
"SELECT ii.* "SELECT ii.*
FROM invoice_items ii FROM invoice_items ii
@@ -54,17 +48,16 @@ if (isset($_GET['item_id'])) {
ORDER BY ii.item_order ASC, ii.item_id ASC ORDER BY ii.item_order ASC, ii.item_id ASC
LIMIT $limit OFFSET $offset" LIMIT $limit OFFSET $offset"
); );
} else { } else {
// All items across all invoices in scope (paginated) // No filter supplied — reject the request
$sql = mysqli_query($mysqli, http_response_code(400);
"SELECT ii.* echo json_encode([
FROM invoice_items ii 'success' => 'False',
INNER JOIN invoices i ON i.invoice_id = ii.item_invoice_id 'message' => 'A filter is required. Please supply either invoice_id or item_id.',
WHERE i.invoice_client_id LIKE '$client_id' 'count' => 0,
ORDER BY ii.item_invoice_id ASC, ii.item_order ASC, ii.item_id ASC 'data' => []
LIMIT $limit OFFSET $offset" ]);
); exit;
} }
// Output // Output