From 2c09ce097c257412b50514662d2d35f59a40c46f Mon Sep 17 00:00:00 2001 From: johnnyq Date: Thu, 16 Jul 2026 13:10:02 -0400 Subject: [PATCH] More Client Enforcement in modals across the app --- agent/ajax.php | 6 ++++++ agent/modals/asset/asset_link_credential.php | 7 +++++-- agent/modals/asset/asset_link_document.php | 4 +++- agent/modals/asset/asset_link_file.php | 6 +++++- agent/modals/asset/asset_link_service.php | 4 +++- agent/modals/asset/asset_link_software.php | 4 +++- agent/modals/calendar/calendar_event_edit.php | 7 ++++++- agent/modals/contact/contact_link_credential.php | 5 +++-- agent/modals/contact/contact_note_add.php | 4 ++++ agent/modals/expense/expense_copy.php | 12 +++++++++--- agent/modals/expense/expense_refund.php | 10 ++++++++-- agent/modals/quote/quote_edit.php | 7 ++++++- agent/modals/revenue/revenue_edit.php | 4 +++- agent/modals/ticket/ticket_add.php | 4 ++++ agent/modals/ticket/ticket_add_v2.php | 4 ++++ agent/modals/ticket/ticket_assign.php | 8 +++++++- agent/modals/ticket/ticket_billable.php | 4 +++- agent/modals/ticket/ticket_change_client.php | 8 +++++++- agent/modals/ticket/ticket_contact.php | 7 +++++-- agent/modals/ticket/ticket_edit.php | 9 ++++++++- agent/modals/ticket/ticket_edit_asset.php | 10 ++++++++-- agent/modals/ticket/ticket_edit_project.php | 9 +++++++-- agent/modals/ticket/ticket_edit_schedule.php | 10 ++++++++-- agent/modals/ticket/ticket_edit_vendor.php | 8 +++++++- agent/modals/ticket/ticket_invoice_add.php | 4 ++++ agent/modals/ticket/ticket_merge.php | 6 +++++- agent/modals/ticket/ticket_priority.php | 10 +++++++--- agent/modals/ticket/ticket_quote_add.php | 4 +++- agent/modals/transfer/transfer_edit.php | 4 +++- agent/modals/vendor/vendor_add.php | 4 ++++ agent/modals/vendor/vendor_details.php | 5 +++++ agent/modals/vendor/vendor_edit.php | 5 +++++ agent/post/ticket.php | 1 - agent/recurring_invoice.php | 4 ++++ 34 files changed, 172 insertions(+), 36 deletions(-) diff --git a/agent/ajax.php b/agent/ajax.php index 4bf9cfdf..a7c8207a 100644 --- a/agent/ajax.php +++ b/agent/ajax.php @@ -49,6 +49,8 @@ if (isset($_POST['client_set_notes'])) { $client_id = intval($_POST['client_id']); $notes = escapeSql($_POST['notes']); + enforceClientAccess(); + // Update notes mysqli_query($mysqli, "UPDATE clients SET client_notes = '$notes' WHERE client_id = $client_id"); @@ -74,6 +76,8 @@ if (isset($_POST['contact_set_notes'])) { $contact_name = escapeSql($row['contact_name']); $client_id = intval($row['contact_client_id']); + enforceClientAccess(); + // Update notes mysqli_query($mysqli, "UPDATE contacts SET contact_notes = '$notes' WHERE contact_id = $contact_id"); @@ -99,6 +103,8 @@ if (isset($_POST['asset_set_notes'])) { $asset_name = escapeSql($row['asset_name']); $client_id = intval($row['asset_client_id']); + enforceClientAccess(); + // Update notes mysqli_query($mysqli, "UPDATE assets SET asset_notes = '$notes' WHERE asset_id = $asset_id"); diff --git a/agent/modals/asset/asset_link_credential.php b/agent/modals/asset/asset_link_credential.php index caca3882..eace6a39 100644 --- a/agent/modals/asset/asset_link_credential.php +++ b/agent/modals/asset/asset_link_credential.php @@ -2,6 +2,8 @@ require_once '../../../includes/modal_header.php'; +enforceUserPermission('module_credential', 2); + $asset_id = intval($_GET['id']); $sql = mysqli_query($mysqli, "SELECT * FROM assets @@ -13,7 +15,8 @@ $row = mysqli_fetch_assoc($sql); $asset_name = escapeHtml($row['asset_name']); $client_id = intval($row['asset_client_id']); -// Generate the HTML form content using output buffering. +enforceClientAccess(); + ob_start(); ?> @@ -66,5 +69,5 @@ ob_start(); diff --git a/agent/modals/asset/asset_link_document.php b/agent/modals/asset/asset_link_document.php index b8c3f35e..59b3ab43 100644 --- a/agent/modals/asset/asset_link_document.php +++ b/agent/modals/asset/asset_link_document.php @@ -13,7 +13,8 @@ $row = mysqli_fetch_assoc($sql); $asset_name = escapeHtml($row['asset_name']); $client_id = intval($row['asset_client_id']); -// Generate the HTML form content using output buffering. +enforceClientAccess(); + ob_start(); ?> @@ -67,4 +68,5 @@ ob_start(); @@ -70,4 +73,5 @@ ob_start(); @@ -66,4 +67,5 @@ ob_start(); @@ -71,4 +72,5 @@ ob_start(); +