From 3d80d1519e7b0fbaa184a116ef195a0f757f7421 Mon Sep 17 00:00:00 2001
From: johnnyq <johnny@pittpc.com>
Date: Mon, 2 Mar 2026 17:32:18 -0500
Subject: [PATCH] Recurring Expenses: Add missing CSRF, Add missing permission
 checks

---
 .../recurring_expense/recurring_expense_add.php     |  1 +
 .../recurring_expense/recurring_expense_edit.php    |  4 +++-
 agent/post/recurring_expense.php                    | 13 +++++++++++++
 agent/recurring_expenses.php                        |  2 +-
 4 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/agent/modals/recurring_expense/recurring_expense_add.php b/agent/modals/recurring_expense/recurring_expense_add.php
index 1cc4130a..5f258faf 100644
--- a/agent/modals/recurring_expense/recurring_expense_add.php
+++ b/agent/modals/recurring_expense/recurring_expense_add.php
@@ -14,6 +14,7 @@ ob_start();
     </button>
 </div>
 <form action="post.php" method="post" autocomplete="off">
+    <input type="hidden" name="csrf_token" value="<?= $_SESSION['csrf_token'] ?>">
     <div class="modal-body">
 
         <div class="form-row">
diff --git a/agent/modals/recurring_expense/recurring_expense_edit.php b/agent/modals/recurring_expense/recurring_expense_edit.php
index 050ef41e..de785e44 100644
--- a/agent/modals/recurring_expense/recurring_expense_edit.php
+++ b/agent/modals/recurring_expense/recurring_expense_edit.php
@@ -36,8 +36,10 @@ ob_start();
     </button>
 </div>
 <form action="post.php" method="post" autocomplete="off">
+    <input type="hidden" name="csrf_token" value="<?= $_SESSION['csrf_token'] ?>">
+    <input type="hidden" name="recurring_expense_id" value="<?php echo $recurring_expense_id; ?>">
+
     <div class="modal-body">
-        <input type="hidden" name="recurring_expense_id" value="<?php echo $recurring_expense_id; ?>">
 
         <div class="form-row">
 
diff --git a/agent/post/recurring_expense.php b/agent/post/recurring_expense.php
index f1256de5..5a7cc545 100644
--- a/agent/post/recurring_expense.php
+++ b/agent/post/recurring_expense.php
@@ -8,6 +8,10 @@ defined('FROM_POST_HANDLER') || die("Direct file access is not allowed");
 
 if (isset($_POST['create_recurring_expense'])) {
 
+    validateCSRFToken($_POST['csrf_token']);
+
+    enforceUserPermission('module_financial', 2);
+
     $frequency = intval($_POST['frequency']);
     $day = intval($_POST['day']);
     $month = intval($_POST['month']);
@@ -39,6 +43,10 @@ if (isset($_POST['create_recurring_expense'])) {
 
 if (isset($_POST['edit_recurring_expense'])) {
 
+    validateCSRFToken($_POST['csrf_token']);
+
+    enforceUserPermission('module_financial', 2);
+
     $recurring_expense_id = intval($_POST['recurring_expense_id']);
     $frequency = intval($_POST['frequency']);
     $day = intval($_POST['day']);
@@ -68,6 +76,11 @@ if (isset($_POST['edit_recurring_expense'])) {
 }
 
 if (isset($_GET['delete_recurring_expense'])) {
+
+    validateCSRFToken($_GET['csrf_token']);
+
+    enforceUserPermission('module_financial', 2);
+
     $recurring_expense_id = intval($_GET['delete_recurring_expense']);
 
     // Get Recurring Expense Details for Logging
diff --git a/agent/recurring_expenses.php b/agent/recurring_expenses.php
index 3568ccd5..27262add 100644
--- a/agent/recurring_expenses.php
+++ b/agent/recurring_expenses.php
@@ -188,7 +188,7 @@ $num_rows = mysqli_fetch_row(mysqli_query($mysqli, "SELECT FOUND_ROWS()"));
                                             <i class="fas fa-fw fa-edit mr-2"></i>Edit
                                         </a>
                                         <div class="dropdown-divider"></div>
-                                        <a class="dropdown-item text-danger text-bold confirm-link" href="post.php?delete_recurring_expense=<?php echo $recurring_expense_id; ?>">
+                                        <a class="dropdown-item text-danger text-bold confirm-link" href="post.php?delete_recurring_expense=<?= $recurring_expense_id ?>&csrf_token=<?= $_SESSION['csrf_token'] ?>">
                                             <i class="fas fa-fw fa-trash mr-2"></i>Delete
                                         </a>
                                     </div>