From 7709627e5ba683780cb59130d0d47f79101c6962 Mon Sep 17 00:00:00 2001
From: o-psi <andymalsb@gmail.com>
Date: Fri, 22 Dec 2023 16:19:51 +0000
Subject: [PATCH 1/2] Accounting module disable ticket billable options

---
 ticket.php            | 12 ++++++------
 ticket_edit_modal.php |  5 ++++-
 tickets.php           | 44 ++++++++++++++++++++++++++++---------------
 3 files changed, 39 insertions(+), 22 deletions(-)

diff --git a/ticket.php b/ticket.php
index 1179fb99..c9c82969 100644
--- a/ticket.php
+++ b/ticket.php
@@ -638,7 +638,7 @@ if (isset($_GET['ticket_id'])) {
                         </div>
                     <?php } ?>
 
-                    <?php if (!empty($ticket_billable)) { ?>
+                    <?php if ($config_module_enable_accounting) { ?>
                         <div class="mt-1">
                             <i class="fa fa-fw fa-dollar-sign text-secondary ml-1 mr-2"></i>Billable:
                             <a href="#" data-toggle="modal" data-target="#editTicketBillableModal<?php echo $ticket_id; ?>">
@@ -830,7 +830,7 @@ if (isset($_GET['ticket_id'])) {
                 </form>
 
                 <div class="card card-body card-outline card-dark mb-2">
-                    <?php if ($config_module_enable_accounting) { ?>
+                    <?php if ($config_module_enable_accounting && $ticket_billable == 1) { ?>
                         <a href="#" class="btn btn-info btn-block" href="#" data-toggle="modal" data-target="#addInvoiceFromTicketModal">
                             <i class="fas fa-fw fa-file-invoice mr-2"></i>Invoice Ticket
                         </a>
@@ -864,10 +864,10 @@ if (isset($_GET['ticket_id'])) {
 
         require_once "ticket_merge_modal.php";
 
-        require_once "ticket_invoice_add_modal.php";
-
-        require_once "ticket_edit_billable_modal.php";
-
+        if ($config_module_enabled_accounting) {
+            require_once "ticket_edit_billable_modal.php";
+            require_once "ticket_invoice_add_modal.php";
+        }
 
     }
 
diff --git a/ticket_edit_modal.php b/ticket_edit_modal.php
index 63e35c14..48273dad 100644
--- a/ticket_edit_modal.php
+++ b/ticket_edit_modal.php
@@ -62,6 +62,8 @@
                                 </div>
                             </div>
 
+                            <?php if ($config_module_enabled_accounting) {
+                                ?>
                             <div class="form-group">
                                 <label>Billable</label>
                                 <div class="input-group">
@@ -73,8 +75,9 @@
                                         <option <?php if ($ticket_billable == 0) { echo "selected"; } ?> value="0">No</option>
                                     </select>
                                 </div>
-
                             </div>
+                            <?php } ?>
+
 
                         </div>
 
diff --git a/tickets.php b/tickets.php
index b4a27bc8..04ddafe3 100644
--- a/tickets.php
+++ b/tickets.php
@@ -243,30 +243,36 @@ $user_active_assigned_tickets = intval($row['total_tickets_assigned']);
                 } ?>">
                 <tr>
                     <th><a class="text-dark"
-                           href="?<?php echo $url_query_strings_sort; ?>&sort=ticket_number&order=<?php echo $disp; ?>">Number</a>
+                        href="?<?php echo $url_query_strings_sort; ?>&sort=ticket_number&order=<?php echo $disp; ?>">Number</a>
                     </th>
                     <th><a class="text-dark"
-                           href="?<?php echo $url_query_strings_sort; ?>&sort=ticket_subject&order=<?php echo $disp; ?>">Subject</a>
+                        href="?<?php echo $url_query_strings_sort; ?>&sort=ticket_subject&order=<?php echo $disp; ?>">Subject</a>
                     </th>
                     <th><a class="text-dark"
-                           href="?<?php echo $url_query_strings_sort; ?>&sort=client_name&order=<?php echo $disp; ?>">Client / Contact</a>
+                        href="?<?php echo $url_query_strings_sort; ?>&sort=client_name&order=<?php echo $disp; ?>">Client / Contact</a>
+                    </th>
+                    <?php if ($config_module_enabled_accounting) {
+                        ?>
+                        <th class="text-center"><a class="text-dark"
+                            href="?<?php echo $url_query_strings_sort; ?>&sort=ticket_billable&order=<?php echo $disp; ?>">Billable</a>
+                        </th>
+                        <?php
+                    }
+                    ?>
+
+                    <th><a class="text-dark"
+                        href="?<?php echo $url_query_strings_sort; ?>&sort=ticket_priority&order=<?php echo $disp; ?>">Priority</a>
                     </th>
                     <th><a class="text-dark"
-                           href="?<?php echo $url_query_strings_sort; ?>&sort=ticket_billable&order=<?php echo $disp; ?>">Billable</a>
+                        href="?<?php echo $url_query_strings_sort; ?>&sort=ticket_status&order=<?php echo $disp; ?>">Status</a>
+                    <th><a class="text-dark"
+                        href="?<?php echo $url_query_strings_sort; ?>&sort=user_name&order=<?php echo $disp; ?>">Assigned</a>
                     </th>
                     <th><a class="text-dark"
-                           href="?<?php echo $url_query_strings_sort; ?>&sort=ticket_priority&order=<?php echo $disp; ?>">Priority</a>
+                        href="?<?php echo $url_query_strings_sort; ?>&sort=ticket_updated_at&order=<?php echo $disp; ?>">Last Response</a>
                     </th>
                     <th><a class="text-dark"
-                           href="?<?php echo $url_query_strings_sort; ?>&sort=ticket_status&order=<?php echo $disp; ?>">Status</a>
-                    <th><a class="text-dark"
-                           href="?<?php echo $url_query_strings_sort; ?>&sort=user_name&order=<?php echo $disp; ?>">Assigned</a>
-                    </th>
-                    <th><a class="text-dark"
-                           href="?<?php echo $url_query_strings_sort; ?>&sort=ticket_updated_at&order=<?php echo $disp; ?>">Last Response</a>
-                    </th>
-                    <th><a class="text-dark"
-                           href="?<?php echo $url_query_strings_sort; ?>&sort=ticket_created_at&order=<?php echo $disp; ?>">Created</a>
+                        href="?<?php echo $url_query_strings_sort; ?>&sort=ticket_created_at&order=<?php echo $disp; ?>">Created</a>
                     </th>
 
                 </tr>
@@ -361,6 +367,8 @@ $user_active_assigned_tickets = intval($row['total_tickets_assigned']);
 
                             <div class="mt-1"><?php echo $contact_display; ?></div>
                         </td>
+                        <?php if ($config_module_enabled_accounting) {
+                                ?>
                         <td class="text-center">
                             <a href="#" data-toggle="modal" data-target="#editTicketBillableModal<?php echo $ticket_id; ?>">
                             <?php
@@ -370,6 +378,9 @@ $user_active_assigned_tickets = intval($row['total_tickets_assigned']);
                                 echo "<span class='badge badge-pill badge-secondary'>X</span>";
                             }
                         ?></td>
+                        <?php
+                            }
+                        ?>
                         <td><a href="#" data-toggle="modal" data-target="#editTicketPriorityModal<?php echo $ticket_id; ?>"><span class='p-2 badge badge-pill badge-<?php echo $ticket_priority_color; ?>'><?php echo $ticket_priority; ?></span></a></td>
                         <td><span class='p-2 badge badge-pill badge-<?php echo $ticket_status_color; ?>'><?php echo $ticket_status; ?></span></td>
                         <td><a href="#" data-toggle="modal" data-target="#assignTicketModal<?php echo $ticket_id; ?>"><?php echo $ticket_assigned_to_display; ?></a></td>
@@ -390,7 +401,10 @@ $user_active_assigned_tickets = intval($row['total_tickets_assigned']);
 
                         require "ticket_edit_priority_modal.php";
 
-                        require "ticket_edit_billable_modal.php";
+
+                        if ($config_module_enabled_accounting) {
+                            require "ticket_edit_billable_modal.php";
+                        }
 
                     }
 

From eb29f74fab9189358ad68088f49a4adebb1d7065 Mon Sep 17 00:00:00 2001
From: o-psi <andymalsb@gmail.com>
Date: Fri, 22 Dec 2023 16:25:36 +0000
Subject: [PATCH 2/2] fix error messages in log

---
 ticket.php            | 2 +-
 ticket_edit_modal.php | 2 +-
 tickets.php           | 5 ++---
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/ticket.php b/ticket.php
index c9c82969..ca898d4e 100644
--- a/ticket.php
+++ b/ticket.php
@@ -864,7 +864,7 @@ if (isset($_GET['ticket_id'])) {
 
         require_once "ticket_merge_modal.php";
 
-        if ($config_module_enabled_accounting) {
+        if ($config_module_enable_accounting) {
             require_once "ticket_edit_billable_modal.php";
             require_once "ticket_invoice_add_modal.php";
         }
diff --git a/ticket_edit_modal.php b/ticket_edit_modal.php
index 48273dad..2313e61a 100644
--- a/ticket_edit_modal.php
+++ b/ticket_edit_modal.php
@@ -62,7 +62,7 @@
                                 </div>
                             </div>
 
-                            <?php if ($config_module_enabled_accounting) {
+                            <?php if ($config_module_enable_accounting) {
                                 ?>
                             <div class="form-group">
                                 <label>Billable</label>
diff --git a/tickets.php b/tickets.php
index 04ddafe3..8c70b8dd 100644
--- a/tickets.php
+++ b/tickets.php
@@ -251,7 +251,7 @@ $user_active_assigned_tickets = intval($row['total_tickets_assigned']);
                     <th><a class="text-dark"
                         href="?<?php echo $url_query_strings_sort; ?>&sort=client_name&order=<?php echo $disp; ?>">Client / Contact</a>
                     </th>
-                    <?php if ($config_module_enabled_accounting) {
+                    <?php if ($config_module_enable_accounting) {
                         ?>
                         <th class="text-center"><a class="text-dark"
                             href="?<?php echo $url_query_strings_sort; ?>&sort=ticket_billable&order=<?php echo $disp; ?>">Billable</a>
@@ -401,8 +401,7 @@ $user_active_assigned_tickets = intval($row['total_tickets_assigned']);
 
                         require "ticket_edit_priority_modal.php";
 
-
-                        if ($config_module_enabled_accounting) {
+                        if ($config_module_enable_accounting) {
                             require "ticket_edit_billable_modal.php";
                         }